Bug 582445 - IllegalStateException warning reported from GitScopeUtil.collectRelatedChanges
Summary: IllegalStateException warning reported from GitScopeUtil.collectRelatedChanges
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 6.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 6.8   Edit
Assignee: Jörg Kubitz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-21 03:20 EDT by Andrey Loskutov CLA
Modified: 2023-09-22 12:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2023-09-21 03:20:22 EDT 
See https://github.com/eclipse-platform/eclipse.platform.ui/pull/1115 / similar bug 582435.

I see this reported after pulling from master.

java.lang.IllegalStateException: beginTask should only be called once per instance. At least call done() before further invocations
	at org.eclipse.jface.operation.AccumulatingProgressMonitor.beginTask(AccumulatingProgressMonitor.java:148)
	at org.eclipse.core.runtime.SubMonitor.convert(SubMonitor.java:483)
	at org.eclipse.core.runtime.SubMonitor.convert(SubMonitor.java:449)
	at org.eclipse.egit.ui.internal.operations.GitScopeUtil.collectRelatedChanges(GitScopeUtil.java:172)
	at org.eclipse.egit.ui.internal.operations.GitScopeUtil$1.run(GitScopeUtil.java:150)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
Caused by: java.lang.IllegalStateException: beginTask(Looking for uncommitted changes, 100) was called here previously
	at org.eclipse.jface.operation.AccumulatingProgressMonitor.beginTask(AccumulatingProgressMonitor.java:155)
	at org.eclipse.egit.ui.internal.operations.GitScopeUtil$1.run(GitScopeUtil.java:148)
	... 1 more
Comment 1 Andrey Loskutov CLA 2023-09-21 03:20:41 EDT 
@Jörg: could you please check this one?
Comment 2 Andrey Loskutov CLA 2023-09-21 03:49:45 EDT 
Same stack on "replace with head version" action on changed file.
Comment 3 Jörg Kubitz CLA 2023-09-22 03:28:06 EDT 
proposed fix: https://git.eclipse.org/r/c/egit/egit/+/204518