Bug 582090 - Wrong figure auto-size layout of RegionContainer and layout of Region contents
Summary: Wrong figure auto-size layout of RegionContainer and layout of Region contents
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 7.1.1   Edit
Assignee: Maxime Porhel CLA
QA Contact: Maxime Porhel CLA
URL:
Whiteboard: clone
Keywords: triaged
Depends on: 582091 582089
Blocks:
  Show dependency tree
 
Reported: 2023-06-20 04:45 EDT by Maxime Porhel CLA
Modified: 2023-06-25 11:51 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2023-06-20 04:45:41 EDT
+++ This bug was initially created as a clone of Bug #582089 +++

Steps to reproduce: 
* With 
  * Sirius 7.0.x or 7.1.x
  * With BPMN Designer (https://github.com/ObeoNetwork/BPMN-Designer)
  * Import the Travel Agency sample
* Case #1
  * Create a Collaboration diagram
  * Select the tool "Participant et un processus existant"
  * Single click on the diagram 
  * Select "Travel Agency" in the wizard.
  * Layout "KO" :
    * Region content is centered, 
    * RegionContainer notation node is in auto-size but but figure has the default dimension
    * Layout is not stable (Figure are well auto-sized) after a close/reopen diagram (or addition of a new child in the Region)
* Case #2
  * From previous diagram
  * Select the particpant, unset its process from the properties views
  * Check that the participant is in auto-size and emtpy on the diagram
  * Layout "KO" :
    * RegionContainer notation node is in auto-size but but figure has the default dimension
    * Layout is not stable (Figure are well auto-sized) after a close/reopen diagram (or addition of a new child in the Region)
* Case #3
  * Create a new Collaboration diagram
  * Layout OK: Participant is created with Region content layouted, RegionContainer layout is stable and correctly auto-sized.
* Case #4
  * From any previous case, 
  * Move nodes inside the region to right or bottom
  * Scroll bars appears
  * Close and reopen the diagram : no more scrollbars and figure are correctly resized.
  * Layout KO: in auto-size, the RegionContainer should adapt its size to the Region contents.
Comment 1 Maxime Porhel CLA 2023-06-20 04:46:59 EDT
Three proposed fixes for 7.1.x - disabled by default but can be activated with system properties

See details on Bug 582089
Comment 2 Maxime Porhel CLA 2023-06-20 04:53:17 EDT
- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202570 [582090] Do not apply center layout on Region content at creation time

- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202571 [582090] Use model constraint to layout Regions

- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202572 [582090] Enable individual auto-size action and status for Regions
Comment 3 Maxime Porhel CLA 2023-06-23 10:03:03 EDT
Verified on Sirius 7.1.1 with the three system properties set to true.
Comment 4 Pierre-Charles David CLA 2023-06-25 11:51:19 EDT
Available in Sirius Desktop 7.1.1: https://projects.eclipse.org/projects/modeling.sirius/releases/sirius-desktop-7.1.1