Bug 580792 - "Show revision information" is not displayed in gutter in readonly mode
Summary: "Show revision information" is not displayed in gutter in readonly mode
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 6.1   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: 6.4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-23 10:29 EDT by Almaz Nasibullin CLA
Modified: 2022-10-01 09:30 EDT (History)
1 user (show)

See Also:

Attachments
There is no command in gutter, but there is a command in the context menu (38.40 KB, application/octet-stream)
2022-09-23 10:29 EDT, Almaz Nasibullin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Almaz Nasibullin CLA 2022-09-23 10:29:00 EDT 
Created attachment 288757 [details]
There is no command in gutter, but there is a command in the context menu

The command "Show revision information" is not displayed in gutter if the text editor is open in readonly mode. But in the context menu of the editor the command "Show revision information" is displayed.
I'm using the custom text editor that based on XtextEditor.
Comment 1 Thomas Wolf CLA 2022-09-25 14:29:20 EDT 
"Show revision information" depends on a quick diff provider being set. Eclipse Platform, where this is implemented, probably doesn't show the menu items because it thinks that there can be no quick diff if a file is read-only.

This would need to be fixed in Eclipse Platform. It's not EGit's doing.
Comment 2 Thomas Wolf CLA 2022-09-26 15:43:43 EDT 
(In reply to Thomas Wolf from comment #1)
> "Show revision information" depends on a quick diff provider being set.
> Eclipse Platform, where this is implemented, probably doesn't show the menu
> items because it thinks that there can be no quick diff if a file is
> read-only.
> 
> This would need to be fixed in Eclipse Platform. It's not EGit's doing.

Not quite correct. It may be EGit's doing after all. The Eclipse Platform is responsible for the quick diff, and indeed it shows the "Show Quick Diff" toggle only if the editor is modifiable. But Eclipse Platform does nothing with the "Show Revision Information" entry. That is EGit, and EGit wants to add it after the "Show Quick Diff" entry. But if that one isn't there, then neither is the EGit one.
Comment 3 Eclipse Genie CLA 2022-09-27 14:00:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/196070