Bug 579292 - Git Staging view ignores configured Git comment char in Eclipse 4.23
Summary: Git Staging view ignores configured Git comment char in Eclipse 4.23
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: 6.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 579739 (view as bug list)
Depends on: 579325
Blocks:
  Show dependency tree
 
Reported: 2022-03-17 06:28 EDT by Andreas Lück CLA
Modified: 2022-05-31 16:01 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Lück CLA 2022-03-17 06:28:56 EDT
Since Eclipse 4.23 the Git Staging view applies some kind of validation on the commit message before you can perform the commit button. In our team, we prepend each commit message with a '#' character, followed by a number and a commit message. This character is usually used as comments in commit messages, so we changed that character into another one in our Git configurations. Unfortunately, Git Staging view ignores that setting always complains that the commit message is still empty, when I fill it with:

     #12345 This is a meaningful commit message

Can I tackle this issue via any configuration or do you have to fix that, first?
Comment 1 Thomas Wolf CLA 2022-03-17 06:49:17 EDT
core.commentChar is not implemented yet in JGit. It's on my to-do list for 6.2.

See also the EGit New & Noteworthy for 6.1[1], which mention this, and which also points out that core.commentChar is not implemented yet.

A work-around is to set commit.cleanup=whitespace in the git config: that will _not_ remove comment lines, which gives you behavior more like in EGit 6.0.

That is even shown in the video.[2]

[1] https://wiki.eclipse.org/EGit/New_and_Noteworthy/6.1#Commit_Messages
[2] https://youtu.be/GnNnQY5ujFg?t=739
Comment 2 Eclipse Genie CLA 2022-03-18 19:42:03 EDT
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/192074
Comment 4 Thomas Wolf CLA 2022-04-22 13:16:05 EDT
*** Bug 579739 has been marked as a duplicate of this bug. ***
Comment 5 Eclipse Genie CLA 2022-05-31 15:35:53 EDT
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/193855