Bug 578848 - [staging] "Add All to Index" and "Remove All from Index" even stages or unstages items filtered out
Summary: [staging] "Add All to Index" and "Remove All from Index" even stages or unsta...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-19 15:06 EST by Thomas Wolf CLA
Modified: 2022-02-20 05:27 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2022-02-19 15:06:21 EST
To reproduce:

* Have some changes in files with different extensions, say d/a.txt and d/b.java
* Go to the staging view. Choose tree or compact tree representation.
  Should show both files as unstaged.
* Enter *.java in the filter; the a.txt file is hidden from the view
* Add b.java to the index: select folder d, then either drag'n'drop,
  or use the context menu, or the "+" button.
* Observe that the unstaged viewer's title still shows (0/1): the hidden file
  d/a.txt was not added to the index. Good.
* Now unstage b.java again.
* Stage all by clicking the "++" button
* Clear the filter

The "++" button did stage the file d/a.txt, even though it was invisible (filtered from the view). The "--" button behaves the same way.

That is confusing, and was not the idea. These operations to add/remove all items from the index should only operate on visible items. They should not include items filtered out from the view.
Comment 1 Eclipse Genie CLA 2022-02-19 15:13:18 EST
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/190981