Bug 578454 - Reftable implementation doesn't work on Windows
Summary: Reftable implementation doesn't work on Windows
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 6.1   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 6.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-30 12:13 EST by David Ostrovsky CLA
Modified: 2022-02-02 17:16 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Ostrovsky CLA 2022-01-30 12:13:23 EST 
Current reftable implementation doesn't work on Windows,
because it is deleting files, currently used, in auto compaction code path.

JUnit tests are failing see issue 550111.

To verify, that it is not just a test issue, I have built Gerrit@HEAD,
deployed it on Windows, created test repository and converted the format
storage to reftable using SSH command:

  $ ssh admin gerrit convert-ref-storage --format reftable -p test_site

as expected the storage format was successfully converted:

  dostr@DESKTOP-MINGW64 /d/pgm/gerrit_site/git/test_site.git
  $ ls reftable/
  000000000001-000000000001-c3475acc.ref  tables.list

If I create change edit in Gerrit for such a repository and try to publish it,
I'm getting exactly the same stack trace in gerrit log as in the failing JUnit tests: [1].

[1] https://paste.opendev.org/show/812439/