Bug 577983 - FileSnapshot deadlock during fileStoreAttributeCache resolution
Summary: FileSnapshot deadlock during fileStoreAttributeCache resolution
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.1.11   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: 5.1.17   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-28 18:45 EST by Luca Milanesio CLA
Modified: 2021-12-30 18:48 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Milanesio CLA 2021-12-28 18:45:37 EST 
The change [1] uncovered a deadlock issue when resolving the fileStoreAttributeCache for a file.

This has been firstly detected on Gerrit master (see [2]) because of [1] being merged up to master.
It could potentially impact any Gerrit version that is using JGit from v5.1.* onwards and also any other products using JGit.

[1] https://git.eclipse.org/r/c/jgit/jgit/+/187910
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=15491
Comment 1 Eclipse Genie CLA 2021-12-28 19:04:55 EST 
New Gerrit change created: https://git.eclipse.org/r/c/jgit/jgit/+/189176
Comment 2 Luca Milanesio CLA 2021-12-28 19:26:45 EST 
Tested with Gerrit master on RBE and worked:
Target //javatests/com/google/gerrit/pgm:pgm_tests up-to-date:
  bazel-bin/javatests/com/google/gerrit/pgm/pgm_tests.jar
  bazel-bin/javatests/com/google/gerrit/pgm/pgm_tests
INFO: Elapsed time: 109.380s, Critical Path: 109.00s
INFO: 65 processes: 1 internal, 64 remote.
INFO: Build completed successfully, 65 total actions
//javatests/com/google/gerrit/pgm:pgm_tests             PASSED in 7.4s
Comment 3 David Ostrovsky CLA 2021-12-29 01:58:16 EST 
@Luca, thanks for the quick fix.
Comment 4 Luca Milanesio CLA 2021-12-29 19:37:07 EST 
I've done all the merges up to master:
https://git.eclipse.org/r/q/hashtag:%22fix-config-filesnapshot-deadlock%22+(status:open%20OR%20status:merged)