Bug 577913 - History view spawns too many background jobs to load the history
Summary: History view spawns too many background jobs to load the history
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 6.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 6.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-20 13:59 EST by Thomas Wolf CLA
Modified: 2021-12-30 07:47 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2021-12-20 13:59:29 EST 
Reproducer:

1. Enable tracing for org.eclipse.egit.ui/debug, org.eclipse.egit.ui/debug/ui,
   and org.eclipse.egit.ui/debug/ui/historyview.
2. From the JGit repository, open file org.eclipse.jgit.api.AddCommand.
3. Notice that the trace reports after the first backgound job to load the
   history 33 additional background jobs to load that same history. (With the
   find toolbar disabled.)

These 33 additional jobs should not be spawned. They come from the virtual table's SetData handler. It seems that the incremental loading has a problem. Maybe it's good enough to fix the condition for loading the next batch, which looks strange to me, but maybe fixing this would require more invasive changes.
Comment 1 Eclipse Genie CLA 2021-12-21 06:06:42 EST 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/189044