577079 – Allow to skip "Preview" in the Push Commit" dialog

Bug 577079 - Allow to skip "Preview" in the Push Commit" dialog

Summary: Allow to skip "Preview" in the Push Commit" dialog

Status:	RESOLVED FIXED

Alias:	None

Product:	EGit
Classification:	Technology
Component:	UI (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	6.1
Assignee:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2021-11-05 04:34 EDT by Lars Vogel
Modified:	2022-02-24 18:00 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Dialog screenshot (47.18 KB, image/png) 2022-02-17 03:44 EST, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2021-11-05 04:34:27 EDT

The current push dialog requires the user to do a preview. This takes a few seconds and I would prefer to be able to push directly as option.

Could you enable the Finish button in the first page to skip the preview process step?

Comment 1 Lars Vogel

2022-02-17 03:44:45 EST

Created attachment 288065 [details]
Dialog screenshot

Comment 2 Eclipse Genie

2022-02-17 15:56:32 EST

New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/190927

Comment 3 Eclipse Genie

2022-02-18 11:38:30 EST

Gerrit change https://git.eclipse.org/r/c/egit/egit/+/190927 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=8df5d9de20aa2a72b5b9e61c96265d3353df236d

Comment 4 Thomas Wolf

2022-02-18 13:01:45 EST

(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/c/egit/egit/+/190927 was merged to
> [master].
> Commit:
> http://git.eclipse.org/c/egit/egit.git/commit/
> ?id=8df5d9de20aa2a72b5b9e61c96265d3353df236d

With this change, the confirmation page can be skipped initially if a remote exists already. Once the confirmation has been visited, though, it becomes mandatory. (User clicks Preview, then Back.)

Comment 5 Lars Vogel

2022-02-18 13:25:52 EST

Thanks a bunch, Thomas. Make my pushing much easier. :-)

Comment 6 Pierre-Yves Bigourdan

2022-02-24 15:45:53 EST

Have noticed this improvement in the last few days. Thanks, it makes things a little smoother!

Comment 7 Eclipse Genie

2022-02-24 17:33:52 EST

New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/191205

Comment 8 Eclipse Genie

2022-02-24 18:00:07 EST

Gerrit change https://git.eclipse.org/r/c/egit/egit/+/191205 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=c007acae5962a587480c4160a1a8528a5bd0ca79