577045 – [Sequence diagram] Impossible to move or resize an inner combined fragment

Bug 577045 - [Sequence diagram] Impossible to move or resize an inner combined fragment

Summary: [Sequence diagram] Impossible to move or resize an inner combined fragment

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	6.4.1
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	6.6.0
Assignee:	Maxime Porhel
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Duplicates (1):	577298 (view as bug list)
Depends on:
Blocks:	577298 577299
	Show dependency tree

Reported:	2021-11-03 13:46 EDT by Laurent Fasani
Modified:	2021-12-17 13:11 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Gerrit Change

Attachments
interactionsModelingProject (5.19 KB, application/x-zip-compressed) 2021-11-03 13:46 EDT, Laurent Fasani	no flags	Details
Analysis of the issue (319.26 KB, image/png) 2021-11-15 11:29 EST, Maxime Porhel	no flags	Details
Analysis of a secondary issue with first simple patch (87.29 KB, image/png) 2021-11-15 11:29 EST, Maxime Porhel	no flags	Details
Additional issue (41.52 KB, image/png) 2021-11-15 12:03 EST, Maxime Porhel	no flags	Details
Additional issue 2 : siblings from not covered lifelines (568.08 KB, image/png) 2021-11-16 05:30 EST, Maxime Porhel	no flags	Details
Validation Scenario (11.08 KB, application/zip) 2021-11-16 07:31 EST, Maxime Porhel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Fasani

2021-11-03 13:46:35 EDT

Steps to reproduce
* import the interactionsModelingProject project from the attached zip file
* open the project and open the sequence diagram
* try to resize the alt.2 combined fragment (from the top or the bottom)
-> KO: it is not possible to do it
* try to move the alt.2 combined fragment (to the top or the bottom)
-> KO: it is not possible to do it

Comment 1 Laurent Fasani

2021-11-03 13:46:56 EDT

Created attachment 287440 [details]
interactionsModelingProject

Comment 2 Eclipse Genie

2021-11-15 11:27:39 EST

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187740

Comment 3 Maxime Porhel

2021-11-15 11:29:05 EST

Created attachment 287517 [details]
Analysis of the issue

Comment 4 Maxime Porhel

2021-11-15 11:29:31 EST

Created attachment 287518 [details]
Analysis of a secondary issue with first simple patch

Comment 5 Maxime Porhel

2021-11-15 11:31:42 EST

Analysis result in images has been attached to this issue. 

The provided patch allows to fix both the initial issue and the ones detected with a first simple fix.

RAF : swtbot tests for correspondings cases.

Comment 6 Maxime Porhel

2021-11-15 12:03:30 EST

Created attachment 287520 [details]
Additional issue

New screenshot to show an additional issue while moving an inner CombinedFragment : we need to check that the future parents belongs to the same Operand. It is not permitted in Sirius Sequence diagrams to have InteractionUse or CombinedFragment which are not fully contained by only one parent Operand (other possibility : no parent operand at all)

Comment 7 Eclipse Genie

2021-11-15 18:35:16 EST

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187760

Comment 8 Eclipse Genie

2021-11-16 05:24:28 EST

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187778

Comment 9 Maxime Porhel

2021-11-16 05:30:22 EST

Created attachment 287527 [details]
Additional issue 2 : siblings from not covered lifelines

Comment 10 Maxime Porhel

2021-11-16 07:31:49 EST

Created attachment 287528 [details]
Validation Scenario

Steps to validate: 
- download the Validation Scenario zipped project from the attachments of this ticket.
- import it in your validation environment
- open the project, open the diagram
- see the two validation scenario described in notes : they indicate which CombinedFragment to select and move and the expected displayed feedback.

Comment 11 Eclipse Genie

2021-11-16 21:14:54 EST

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187803

Comment 12 Eclipse Genie

2021-11-17 05:38:53 EST

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187740 was merged to [v6.6.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=70f4000091d231b7452962a7bf22ad848930eee2

Comment 13 Eclipse Genie

2021-11-17 08:31:49 EST

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187760 was merged to [v6.6.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=24a8d325329690c6ed3865127d44c41bd93ea369

Comment 14 Maxime Porhel

2021-11-17 08:39:09 EST

*** Bug 577298 has been marked as a duplicate of this bug. ***

Comment 15 Eclipse Genie

2021-11-17 08:44:45 EST

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187778 was merged to [v6.6.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0e45fdecc82e04f782a142290d0e0518291fe8c2

Comment 16 Pierre-Charles David

2021-12-10 04:07:08 EST

Available in Sirius 6.6.0: https://projects.eclipse.org/projects/modeling.sirius/releases/6.6.0

Comment 17 Eclipse Genie

2021-12-17 13:11:50 EST

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/187803 was merged to [v6.6.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4f02cb4fe2ef56aba411b1eb9164711e1e9b7b09

Comment 18 Eclipse Genie

2021-12-17 13:11:51 EST

New Gerrit change created: https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/188341