Community
Participate
Working Groups
Created attachment 287042 [details] feature start dialog with error In case of input errors (e.g. invalid symbols), the dialog to start a feature branch would display an error message. If the branch-name gets very long, the end of the message would be cut off, and the message would not help the user resolve the problem. See attached screenshot.
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/184743
Gerrit change https://git.eclipse.org/r/c/egit/egit/+/184743 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=2bc8a7ef1c5adf74a8f853c33ab83e052cf097ba
That's an ugly work-around. Did you actually resize the dialog? At least on OS X, the layout is ugly; the message above the text input field grabs way too much space. One way of improving this might be to omit the branch name from the error message; the user sees it anyway in the text input field. But even then the error message might still get too long, depending on what the validator returns. A better way IMO is to make the dialog adjust its size automatically such that it can display the whole message. (Note that the error message label has SWT.WRAP set.)
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/184907
It looked ok on Ubuntu. Sure, you can resize it to a point where the layouting does not make sense anymore, but why would you want to do that? If you are just interested in the full error message you'd just extend the dialog horizontally to make room for a few more words. Could you share a screenshot of how it looks like in OS X? I agree it's a workaround. I would've preferred inserting ellipsis in the branch name, but didn't want to spend that kind of effort, for what I think, is a corner-case. I see you already provided a different solution. I'll try to have a look, but don't know yet when I'll get to it.
Gerrit change https://git.eclipse.org/r/c/egit/egit/+/184907 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=f1ee0df2e4ae0f989aa9facff7262b297d8f558d
Created attachment 287128 [details] gtiflow start feature error still hidden I think the new fix will work in many cases, but not in all. The dialog now resizes on input, but only seems to extends for one additional row of text. See screenshot (taken on Ubuntu). Let me know if you think that could be improved without too much effort, and I might take another look.
