Community
Participate
Working Groups
Created attachment 286812 [details] Visual example of area that jaws does not read in Clone Git Repository wizard on the Branch Selection page In the Clone Git Repository wizard on the Branch Selection page, the label Branches of file: <contents> is not read aloud by Jaws. Investigation of the code quickly leads to the assumption that it is due to being a label not associated with text field as the what looks like a field that would be associated to the label is actually a part of the FilteredCheckboxTree. org.eclipse.egit.ui.internal.clone.SourceBranchPage line 137: label = new Label(panel, SWT.NONE); line 138: label.setLayoutData(new GridData(SWT.FILL, SWT.TOP, true, false)); line 337: label.setText(NLS.bind(UIText.SourceBranchPage_branchList, line 337: newRepoSelection.getURI().toString())); One possible solution is to make the label into a read-only Text control. This would enable the user to set the focus to the label and allow Jaws to read the contents. Another is to have the filtered tree and possibly the buttons as part of a group.
Using a Group gives a completely unnecessary border. Support for screen readers should not compromise visual layout. Changing labels to read-only texts gives other side effects. You get a context menu with, depending on the OS, several nonsensical menu entries. Using a read-only StyledText might be a possibility. Anyway, a screen reader would not discover the connection between the FilteredTree and the label, and read the "label" only if focused. But it seems to me that adding an AccessibilityAdapter to the FilteredCheckboxTree search field might work. Something like FilteredCheckboxTree fTree = ...; fTree.getFilterControl().getAccessible() .addAccessibleListener(new AccessibleAdapter() { @Override public void getName(AccessibleEvent e) { e.result = label.getText(); } }); might do the trick. That should make the reader read the label when the search field is focused (which it is initially). Could you give that a try, please? I don't have Windows, nor JAWS, so I can't really verify this. It does work with VoiceOver on Mac: it reads the label, tells me it's a search field, and that I should type text to filter branches. If it also works for JAWS, other places where FilteredTrees or FilteredCheckboxTrees are used should be examined and if needed also be changed in a similar way.
Thank you. I will try that and report back.
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/183359
Gerrit change https://git.eclipse.org/r/c/egit/egit/+/183359 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=7e33345e72b15d75db1df14acfd901f5d899b829
@Gerald, feel free to re-open if it shouldn't work well enough with JAWS.
Sorry for the late reply. I seemed to have missed updating the bBgzilla. that seemed to do the trick. Thank you! Tested 2021-08-12 Windows 10, JAWS 2021, Eclipse 2021-03
