Bugzilla will undergo maintenance 2024-03-29 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 573646 - Restore open terminals to correct secondary views
Summary: Restore open terminals to correct secondary views
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 10.3.0   Edit
Assignee: Jonah Graham CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-19 12:55 EDT by Jonah Graham CLA
Modified: 2021-05-24 16:45 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2021-05-19 12:55:39 EDT
On restarting the IDE if terminals are open in multiple views, some of the terminals restore to the wrong view:

(In reply to Martin Oberhuber from Bug 460495 comment #2)
> Also, when 2 terminal instances are open, after a File > Restart all
> terminal are restored in the secondary instance.
> 
> Expected: Terminals should be restored in the instance in which they were
> open previously. Otherwise the screen layout is destroyed, causing more
> annoyance than value.
Comment 1 Eclipse Genie CLA 2021-05-19 13:19:24 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180786
Comment 3 Jonah Graham CLA 2021-05-19 23:42:26 EDT
Done and added to N&N https://wiki.eclipse.org/CDT/User/NewIn103#Terminal
Comment 4 Jonah Graham CLA 2021-05-20 20:41:29 EDT
If the first terminal is opened with a Ctrl-Shift-Alt-T shortcut, the name of the terminal view is "Terminal last" which means that the magic code "last" is being passed to the wrong place and being interpreted as the secondaryId instead of being one of the codes.

I think I am going to revisit this again and probably use an enum for the different types and add a new key because the special values that were and continue to be in the code base is too error prone.
Comment 5 Jonah Graham CLA 2021-05-23 09:32:18 EDT
(In reply to Jonah Graham from comment #4)
> I think I am going to revisit this again and probably use an enum for the
> different types and add a new key because the special values that were and
> continue to be in the code base is too error prone.

Revisited without using an emum.
Comment 6 Eclipse Genie CLA 2021-05-23 09:33:39 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180926