Bugzilla will undergo maintenance 2024-03-29 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 573157 - Opcodes in Disassembly view should be editable
Summary: Opcodes in Disassembly view should be editable
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: Next   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 10.3.0   Edit
Assignee: Marc Ernst CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 01:59 EDT by Marc Ernst CLA
Modified: 2021-05-05 12:40 EDT (History)
2 users (show)

See Also:


Attachments
edit memory browser (307.72 KB, image/gif)
2021-05-04 12:54 EDT, Jonah Graham CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Ernst CLA 2021-04-26 01:59:46 EDT
It should be possible to edit the opcode bytes.

As discussed already in Bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=572880 the disassembly ruler column does not allow to do inline edit.
The solution might be a new dialog to edit the bytes or maybe a jump to memory view context menu entry.
Comment 1 Jonah Graham CLA 2021-04-26 09:23:18 EDT
> jump to memory view context menu entry

:-) That is a good idea if you can't make the ruler an editable control. If a solution can be done without a modal dialog that would generally be my preference.
Comment 2 Marc Ernst CLA 2021-04-29 05:16:01 EDT
Hi Jonah,
I've seen that the CDT memory browser is not capable of editing the memory, is this true? The memory view can be used for editing but I've not seen an API to do a jump to memory address.
I'm not sure what is more prefereable here, add memory editing support to the memory browser or extend the API of the memory view. If both is not an option we have to go with the dialog or looking for some inline editing ruler support.

Thanks,
Marc
Comment 3 Eclipse Genie CLA 2021-05-04 07:10:59 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180162
Comment 4 Jonah Graham CLA 2021-05-04 12:54:45 EDT
Created attachment 286311 [details]
edit memory browser

Hi Marc,

I missed Comment 2 until now.

(In reply to Marc Ernst from comment #2)
> I've seen that the CDT memory browser is not capable of editing the memory,
> is this true? 

That is not true, you can edit in memory browser. I attached an animated gif showing that. I press 0 a bunch of times, then enter, then refresh.

> The memory view can be used for editing but I've not seen an
> API to do a jump to memory address.
You have found a way to do it. I don't know if there is a way to move an existing rendering to a new address. 

> I'm not sure what is more prefereable here, add memory editing support to
> the memory browser or extend the API of the memory view. If both is not an
> option we have to go with the dialog or looking for some inline editing
> ruler support.
I think your current version wins on simplicity. You could potentially add controls to DisassemblyRulerColumn, but I don't know for sure I suspect it would be a lot more work.

> 
> Thanks,
> Marc

Thanks for the patch and I hope the above helped.
Jonah
Comment 6 Jonah Graham CLA 2021-05-05 11:58:51 EDT
Thanks Marc for the patch.

Please add a N&N[1] entry at your convenience and we can close off this issue.

[1] https://wiki.eclipse.org/CDT/User/NewIn103#Debug
Comment 7 Marc Ernst CLA 2021-05-05 12:40:53 EDT
Hi Jonah,
I added the N&N. Was nice to work with you.

Thanks a lot.
Marc