Community
Participate
Working Groups
It should be possible to edit the opcode bytes. As discussed already in Bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=572880 the disassembly ruler column does not allow to do inline edit. The solution might be a new dialog to edit the bytes or maybe a jump to memory view context menu entry.
> jump to memory view context menu entry :-) That is a good idea if you can't make the ruler an editable control. If a solution can be done without a modal dialog that would generally be my preference.
Hi Jonah, I've seen that the CDT memory browser is not capable of editing the memory, is this true? The memory view can be used for editing but I've not seen an API to do a jump to memory address. I'm not sure what is more prefereable here, add memory editing support to the memory browser or extend the API of the memory view. If both is not an option we have to go with the dialog or looking for some inline editing ruler support. Thanks, Marc
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180162
Created attachment 286311 [details] edit memory browser Hi Marc, I missed Comment 2 until now. (In reply to Marc Ernst from comment #2) > I've seen that the CDT memory browser is not capable of editing the memory, > is this true? That is not true, you can edit in memory browser. I attached an animated gif showing that. I press 0 a bunch of times, then enter, then refresh. > The memory view can be used for editing but I've not seen an > API to do a jump to memory address. You have found a way to do it. I don't know if there is a way to move an existing rendering to a new address. > I'm not sure what is more prefereable here, add memory editing support to > the memory browser or extend the API of the memory view. If both is not an > option we have to go with the dialog or looking for some inline editing > ruler support. I think your current version wins on simplicity. You could potentially add controls to DisassemblyRulerColumn, but I don't know for sure I suspect it would be a lot more work. > > Thanks, > Marc Thanks for the patch and I hope the above helped. Jonah
Gerrit change https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180162 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=335437d667177cc1307741e8e2cb88c2ba189288
Thanks Marc for the patch. Please add a N&N[1] entry at your convenience and we can close off this issue. [1] https://wiki.eclipse.org/CDT/User/NewIn103#Debug
Hi Jonah, I added the N&N. Was nice to work with you. Thanks a lot. Marc