Bug 569080 - Add some additional Batik 1.13.0 bundles
Summary: Add some additional Batik 1.13.0 bundles
Status: NEW
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2020-12 RC1   Edit
Assignee: Orbit Bundles CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-23 16:22 EST by Roland Grunberg CLA
Modified: 2021-05-12 03:34 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Grunberg CLA 2020-11-23 16:22:20 EST
See https://www.eclipse.org/lists/orbit-dev/msg05360.html . This has been requested and worked on since the end of September.
Comment 1 Christoph Laeubrich CLA 2020-11-24 01:16:02 EST
That sounds great, will this include all the missing ones mentioned here [1]?

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=568215#c9
Comment 2 Roland Grunberg CLA 2020-11-24 10:09:52 EST
(In reply to Christoph Laeubrich from comment #1)
> That sounds great, will this include all the missing ones mentioned here [1]?
> 
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=568215#c9

Yes, these should all be included.
Comment 3 Christoph Laeubrich CLA 2020-11-26 07:49:13 EST
Perfect, does 2020-12 RC1
 mean its already available somewhere? Or will it be released with the 2020-12 release of eclipse?
Comment 4 Roland Grunberg CLA 2020-11-26 09:17:45 EST
You can find the 2020-12 RC1 on the downloads page : http://download.eclipse.org/tools/orbit/downloads/

http://download.eclipse.org/tools/orbit/downloads/drops/S20201124213957/repository for a static repo .

http://download.eclipse.org/tools/orbit/downloads/2020-12/ for what will eventually become the final release.
Comment 5 Christoph Laeubrich CLA 2020-11-26 13:55:33 EST
One thing I have noticed: the new batik bundles seems to have all a name derived from the maven coordinates (org.xmlgraphic.batik:<bundle name>), while the older 1.13 ones have a more descriptive (Batik Utils) name.

I think the new naming scheme is fine as its always a bit odd to guess what bundle is behind the name, maybe the other batik 1.13 once can get the org.xmlgraphic.batik:<bundle name> also so the are grouped nicely together when filtering?

It would also be nice if there would be a master-feature that includes all batik libs for a particular version so one do not need to select them all by hand.
Comment 6 Christoph Laeubrich CLA 2020-11-26 14:31:25 EST
I found one issue it seems that batik.anim is missing an import for org.apache.batik.i18n.LocalizableSupport


I'm getting the following error:
java.lang.ClassNotFoundException: org.apache.batik.i18n.LocalizableSupport cannot be found by org.apache.batik.anim_1.13.0.v20201124-1840

Code that triggers this:
> String parser = XMLResourceDescriptor.getXMLParserClassName();
> SAXSVGDocumentFactory f = new SAXSVGDocumentFactory(parser);
> Document doc = f.createDocument(uri, inputStream);

I patched the manifest and added

> org.apache.batik.i18n;bundle-version="[1.13.0,2)"

as a required bundle then the code runs fine.
Comment 7 Roland Grunberg CLA 2020-11-30 10:44:41 EST
(In reply to Christoph Laeubrich from comment #6)
> I found one issue it seems that batik.anim is missing an import for
> org.apache.batik.i18n.LocalizableSupport
> 
> 
> I'm getting the following error:
> java.lang.ClassNotFoundException: org.apache.batik.i18n.LocalizableSupport
> cannot be found by org.apache.batik.anim_1.13.0.v20201124-1840
> 
> Code that triggers this:
> > String parser = XMLResourceDescriptor.getXMLParserClassName();
> > SAXSVGDocumentFactory f = new SAXSVGDocumentFactory(parser);
> > Document doc = f.createDocument(uri, inputStream);
> 
> I patched the manifest and added
> 
> > org.apache.batik.i18n;bundle-version="[1.13.0,2)"
> 
> as a required bundle then the code runs fine.

I can probably add this to the build just before doing the final release. If there's other issues that come up, I likely won't be able to address them until the next release.
Comment 8 Christoph Laeubrich CLA 2020-11-30 10:49:46 EST
That would be good, beside from this all seems to work as expected!
Comment 9 Christoph Laeubrich CLA 2020-12-02 01:25:32 EST
Thanks for the change, everything seems to work now as expected!
Comment 10 Daniel Raap CLA 2021-05-12 03:34:32 EDT
Hi, we found a problem using batik 1.13 from Orbit. I add it here instead of a new issues as it is still open.

The PNGTranscoder of batik-transcoder cannot load a WriteAdapter because the class loader does not know about the package "org.apache.batik.ext.awt.image.codec.png".

We previously generated OSGi bundles by ourselves for Batik. There we added the dependency to batik-codec by adding the package 'org.apache.batik.ext.awt.image.codec.png' to the Import-Package directive.

Without that we need to overwrite the method in PNGTranscoder to be able to write PNG images.

Maybe you can add it to the Orbit bundles?