Bug 567910 - Plug-in 'org.eclipse.egit.ui' contributed an invalid Menu Extension (Path: 'org.eclipse.search.menu' is invalid): org.eclipse.egit.ui.actions.OpenCommitSearchPage
Summary: Plug-in 'org.eclipse.egit.ui' contributed an invalid Menu Extension (Path: 'o...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.9   Edit
Hardware: PC Linux
: P3 normal with 3 votes (vote)
Target Milestone: 5.13   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-15 12:17 EDT by Taro Kyo CLA
Modified: 2021-08-24 07:09 EDT (History)
2 users (show)

See Also:

Attachments
Eclipse IDE for Java/Enterprise 2020-09 with EGit plugin error. (60.70 KB, image/png)
2020-10-15 12:17 EDT, Taro Kyo CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taro Kyo CLA 2020-10-15 12:17:48 EDT 
Created attachment 284470 [details]
Eclipse IDE for Java/Enterprise 2020-09 with EGit plugin error.

EGit should be the latest 5.9, using the recommended main update site:

https://www.eclipse.org/egit/download/

Error re-occurs even when reinstalling a brand new Eclipse for Java/Enterprise version.

=============================

Steps to reproduce:

1. Run Eclipse Oomph Installer.
2. Download and install the latest stable Eclipse IDE for Java/Enterprise 2020-09.
3. Run the newly installed Eclipse IDE for Java/Enterprise 2020-09.
4. Let Eclipse create a brand new empty workspace.
5. At the top, Window -> Show View -> Other...
6. Select "Error Logs".
7. Press OK.
8. At the top, Window -> Customize Perspective...
9. Observe the error below is thrown:

=============================

eclipse.buildId=4.17.0.I20200902-1800
java.version=11.0.8
java.vendor=AdoptOpenJDK
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.jee.product
Command-line arguments:  -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.jee.product

org.eclipse.ui
Error
Thu Oct 15 12:09:33 EDT 2020
Plug-in 'org.eclipse.egit.ui' contributed an invalid Menu Extension (Path: 'org.eclipse.search.menu' is invalid): org.eclipse.egit.ui.actions.OpenCommitSearchPage

=============================

Attached a picture of a brand new Eclipse IDE for Java 2020-09 showing the error.
Comment 1 Fabio Zadrozny CLA 2021-08-18 08:18:57 EDT 
Note: this is still an issue with EGit 5.12 and Eclipse 2021-06.
Comment 2 Thomas Wolf CLA 2021-08-18 10:25:11 EDT 
This is a recurrence of bug 15684. Looks like every plug-in that wants to contribute to that menu must re-declare the action set?!

See also [1].

We may need to do the same. :-(

[1] https://www.eclipse.org/forums/index.php?t=msg&goto=648585&S=0b4e3effd0f243c7f18afd151cd53952#msg_648585
Comment 3 Thomas Wolf CLA 2021-08-18 10:56:11 EDT 
Didn't manage to reproduce in the Committers EPP. But indeed reproducible in the JEE EPP.
Comment 4 Eclipse Genie CLA 2021-08-18 11:08:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/184206
Comment 5 Thomas Wolf CLA 2021-08-18 11:10:59 EDT 
(In reply to Thomas Wolf from comment #2)
> ... must re-declare the action set?!

I meant "must re-declare that menu". 

Issue reproduces also in my usual child eclipse, so I could verify that re-declaring the menu seems to fix this.
Comment 6 Thomas Wolf CLA 2021-08-18 11:27:30 EDT 
BTW, bug 413216 from 2013 seems to be the same issue (but relating to other bundles, not EGit).

It appears this was once a well-known issue; see for instance bug 103203 comment 2. 103203 was closed as a duplicate of the slightly different bug 36389 (there, the action sets are within the same bundle), which in turn was closed as "obsoleted by bug 154130", but that one is still open (even though stale), and AFAIK that whole "migrating actionsets to the command/handler framework" was never completed.