Community
Participate
Working Groups
Hello, From JGit 5.8 JschConfigSessionFactory class was moved to org.eclipse.jgit:org.eclipse.jgit.ssh.jsch artifact Maven. So currently two artifacts share org.eclipse.jgit.transport package: - org.eclipse.jgit:org.eclipse.jgit - org.eclipse.jgit:org.eclipse.jgit.ssh.jsch This leads to JPMS split-package issue. Take a look https://blog.codefx.org/java/java-9-migration-guide/#Split-Packages Could you please rename packages in org.eclipse.jgit:org.eclipse.jgit.ssh.jsch to avoid JPMS split-package issue?
Hi, I created a PR regarding this issue: https://github.com/eclipse/jgit/pull/110 Regards
We don't use Github for code reviews but Gerrit Code Review at [1]. See the contributor guide for details [2]. We did that [3] in order to avoid to breaking compatibility in a minor release by moving public classes to another package. JGit uses OSGi when run in Eclipse and org.eclipse.jgit.ssh.jsch is an OSGi fragment [4] adding classes to its host bundle org.eclipse.jgit when the fragment is available at runtime. We plan to remove support for jsch in the next major release 6.0 [5] due to the reasons discussed in bug 520927. [1] https://git.eclipse.org/r [2] https://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches [3] https://git.eclipse.org/r/c/jgit/jgit/+/156153 [4] https://git.eclipse.org/r/plugins/gitiles/jgit/jgit/+/refs/heads/master/org.eclipse.jgit.ssh.jsch/META-INF/MANIFEST.MF [5] https://wiki.eclipse.org/JGit/Planning#Clean-ups
thank you for your detailed response.
New Gerrit change created: https://git.eclipse.org/r/c/jgit/jgit/+/185345
Gerrit change https://git.eclipse.org/r/c/jgit/jgit/+/185345 was merged to [master]. Commit: http://git.eclipse.org/c/jgit/jgit.git/commit/?id=9683bc71b6c05ce1ca2b5d6c6f7d74fff3db8429
split package issue was fixed on master for 6.0
