559062 – [Xdebug] property_set: some values are not accepted

Bug 559062 - [Xdebug] property_set: some values are not accepted

Summary: [Xdebug] property_set: some values are not accepted

Status:	CLOSED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	PDT (show other bugs)
Version:	unspecified
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Thierry BLIND
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-01-11 11:40 EST by Thierry BLIND
Modified:	2020-05-14 13:16 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Thierry BLIND

2020-01-11 11:40:31 EST

Hi,
while fixing bug 528162, I saw another problem:
when you try to set values containing quotes and backslashes, you'll end up with a popup "program under debug rejected value change".
It seems that we need to protect values before sending them to Xdebug, even if there are base64-encoded.
Sadly the documentation of Xdebug doen't tell much more how to escape values before (base64) encoding them, so let's try to re-use most of the DBGpTarget.escapeFullName() method introduced by patch for bug 528162.

Thierry.

Comment 1 Eclipse Genie

2020-01-11 12:26:17 EST

New Gerrit change created: https://git.eclipse.org/r/155646

Comment 2 Eclipse Genie

2020-01-12 04:37:50 EST

Gerrit change https://git.eclipse.org/r/155646 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=2907bd3246731e9ededb6875d8ded4946fd73873

Comment 3 Thierry BLIND

2020-01-12 04:47:08 EST

Fixed, at least with Xdebug >= 2.7.2

Now you can write values with spaces, double-quotes or backslashes in a variable's value field of the PHP debugger view.
Here are some examples of newly supported values:

a b
""
\0
\\\"

Thierry.