Bug 553116 - CommitCommand.setCredentialsProvider() not fluent
Summary: CommitCommand.setCredentialsProvider() not fluent
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.6   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: 6.0   Edit
Assignee: Alex Blewitt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-15 16:14 EST by Thomas Wolf CLA
Modified: 2021-03-19 11:28 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2019-11-15 16:14:18 EST 
It should return "this".
Comment 1 Alex Blewitt CLA 2021-03-19 07:20:47 EDT 
As noted by Matthias and others, this is a backwards breaking change for clients that have already compiled against it. However, it is a source compatible change since existing clients which build against this will continue to work.

It means that adding this will require a major change to JGit.
Comment 2 Eclipse Genie CLA 2021-03-19 07:28:04 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jgit/jgit/+/178067
Comment 3 Alex Blewitt CLA 2021-03-19 10:03:13 EDT 
There's a suggestion this would be good for JGit 6.0, but I don't see that as a milestone listed here. Could someone create it so we can tag it appropriately?