Bug 549246 - Uninitialized read of hookOutRedirect at Transport.java:826
Summary: Uninitialized read of hookOutRedirect at Transport.java:826
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 5.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 580910
  Show dependency tree
 
Reported: 2019-07-14 06:39 EDT by Thomas Wolf CLA
Modified: 2022-10-21 02:21 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2019-07-14 06:39:36 EDT 
In the Transport(Repository local, URIish uri) constructor. As a result the hook's stdout will always go to System.out.

Might be (part of) the cause of bug 536659.
Comment 1 Tim Neumann CLA 2019-11-28 06:48:40 EST 
The variable hookOutRedirect is actually never assigned to anything ...

But I don't think this is part of the cause for bug 536659 because this is only relevant for pre push hooks and bug 536659 is about pre commit hooks.
Comment 2 Thomas Wolf CLA 2021-10-04 03:12:48 EDT 
This might also be something for JGit 6.0.
Comment 3 Eclipse Genie CLA 2022-10-20 17:30:32 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jgit/jgit/+/196452