Community
Participate
Working Groups
I suggest to mark the deprecated ViewersObservables methods for deletion. Process: https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process
Jens, something for you?
(In reply to Lars Vogel from comment #1) > Jens, something for you? Okay, I'll do this while I also do for the property factories (bug 546822).
Jens, can we start the deprecation? Will be two more years before we can delete them.
I (In reply to Lars Vogel from comment #3) > Jens, can we start the deprecation? Will be two more years before we can > delete them. Oh, I missed this, I can fix it during the weekend.
New Gerrit change created: https://git.eclipse.org/r/163460
There is a lot of other obsolete and deprecated observable factory classes, apart from ViewersObservables: ViwersObservables SWTObservables BeansObservables PojoObservables WorkbenchObservables These other classes were all deprecated in 2014, when the databinding framework was transitioned to work with property objects. The ViewersObservables and WorkbenchObservables classes were probably overlooked at that time, so they were not marked as deprecated. Conclusion: When we mark ViewersObservables for deletion we should probably also mark the other observable factory classes for deletion. I suggest that we change this ticket to include all the classes above. It will then include the following work: * Deprecate WorkbenchObservables * Adjust deprecation on ViwersObservables to apply to the whole class (by mistake I wanted to save one method previously) * Mark all of the above classes for deletion I can start working on this. (But it will probably take a while because I can't spend that much time on it.)
> I suggest that we change this ticket to include all the classes above. +1 > I can start working on this. I think we should target 4.17, 4.16 is already in release freeze, so no pressure.
New Gerrit change created: https://git.eclipse.org/r/163466
New Gerrit change created: https://git.eclipse.org/r/163467
The following Gerrits contains the updates to the code and the update to removals.html: https://git.eclipse.org/r/163466 https://git.eclipse.org/r/163467 This should be finished.
Arg, WorkbenchProperties doesn't contain all functionality that WorkbenchObservers contains. I have to think about how this should be handled.
(In reply to Jens Lideström from comment #11) > Arg, WorkbenchProperties doesn't contain all functionality that > WorkbenchObservers contains. I will add all functionality from WorkbenchObservables to WorkbenchProperties. After that we can deprecate WorkbenchObservables. See the new Bug 564010. The implementation is finished, but the WorkbenchObservables doesn't have unit tests, so ideally I should create some to verify correctness since I'm moving things around...
New Gerrit change created: https://git.eclipse.org/r/165176
Gerrit change https://git.eclipse.org/r/165176 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=90384b2caf1e05a0906142c13cf1aad5948a3957
Gerrit change https://git.eclipse.org/r/163467 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4f25fbf41f9411ded14d3cec0e951e7bcaf51319
Gerrit change https://git.eclipse.org/r/163466 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=a610013191d4229dbbef9fcd4b676968425c0571
All active steps of the removal procedure has been completed. The following has been done: * Added replacement methods to WorbenchProperties (see bug 564010). * Got PMC approval. * Added comments and annotations to the code. * Added a removal note to the Porting Guide. * Announced the removal on the cross-project-issues-dev mailing list. Now only patience is needed.
Thanks Jens, we can mark this one as fixed and open a new bug in 2 years for the deletion.
