Bug 544769 - Cloning: listing branches does not honor URI rewrites from user or system config
Summary: Cloning: listing branches does not honor URI rewrites from user or system config
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 5.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-25 08:01 EST by Thomas Wolf CLA
Modified: 2022-03-22 19:08 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wolf CLA 2019-02-25 08:01:40 EST 
In [1] and [2] the (temporary) repository was removed from the ListRemoteOperation used in SourceBranchPage because of bug 521033.

However, EGit now no longer applies URI rewriting to the repository URI. If a user has e.g.

  [url "ssh://git@github.com/"]
    insteadOf = https://github.com/

in his user config, EGit/JGit should use the SSH URI to list the branches even if the original URI given in the clone wizard was a HTTPS URI for GitHub. Currently EGit will use the HTTPS URI despite the rewrite specification in the user config -- without repository, JGit considers neither user nor system config.

For actual cloning it will then use the SSH URI as specified; cloning creates the repository and sets up the config before running the initial fetch, and so it will respect the setting from the user config.

[1] https://git.eclipse.org/r/#/c/103334/
[2] https://git.eclipse.org/r/#/c/104059/
Comment 1 Eclipse Genie CLA 2022-03-15 16:23:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/jgit/jgit/+/191929