Bugzilla will undergo maintenance 2024-03-29 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 460495 - [TERMINALS] After restart, the terminal's "Git Bash" (which shell to use) setting is lost
Summary: [TERMINALS] After restart, the terminal's "Git Bash" (which shell to use) set...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: All All
: P2 major with 1 vote (vote)
Target Milestone: 10.3.0   Edit
Assignee: Jonah Graham CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords: helpwanted
: 517444 (view as bug list)
Depends on: 443046
Blocks:
  Show dependency tree
 
Reported: 2015-02-20 23:41 EST by Martin Oberhuber CLA
Modified: 2021-05-19 15:01 EDT (History)
11 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2015-02-20 23:41:40 EST
+++ This bug was initially created as a clone of Bug #443046 +++

After restart current directory setting is lost.

I opened 2 local shells selecting UTF-8, and doing some work in different dirs.
After Eclipse restart Terminal View and tabs within are restored, directory location falls back to user home.
Comment 1 Martin Oberhuber CLA 2016-06-05 20:15:50 EDT
Having a Git Bash open on Windows and choosing "File > Restart", that Terminal is restored as a normal Windows CMD prompt.

Expected: Terminals should be faithfully restored with the same settings (shell) they were opened on before. Otherwise, the auto-restore feature is more annoying than useful, thus setting as "Major". See also bug 494652 that requests being able to turn off the auto-reconnect on restart.
Comment 2 Martin Oberhuber CLA 2016-06-05 20:17:05 EDT
Also, when 2 terminal instances are open, after a File > Restart all terminal are restored in the secondary instance.

Expected: Terminals should be restored in the instance in which they were open previously. Otherwise the screen layout is destroyed, causing more annoyance than value.
Comment 3 Martin Oberhuber CLA 2017-05-30 13:10:53 EDT
*** Bug 517444 has been marked as a duplicate of this bug. ***
Comment 4 Martin Oberhuber CLA 2017-05-30 13:13:47 EDT
This is currently one of the most annoying issues in Terminal, code contributions would be most welcome !

As a first step, I'm fine if only the "startup directory" of any terminal is restored on restart. This shouldn't be hard to do -- maybe some of the related bugs can point in the right direction for code contributions:

- https://bugs.eclipse.org/bugs/show_bug.cgi?id=499832
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=496314
- https://bugs.eclipse.org/bugs/show_bug.cgi?id=441652

The other issue of secondary instances not restored in the correct Terminal view or Window could also be tracked as a separate bug (to reproduce that aspect: click the "New Terminal View" button, drag it to some place in the Window, so you now have two terminals side-by-side, then quit and restart).
Comment 5 Jonah Graham CLA 2020-05-01 10:11:11 EDT
The Terminal component of the Eclipse Ecosystem has a new home. The Terminal is now part of the Eclipse CDT project[1].

This change means a new Git repo[2], P2 site[3] and Bugzilla component. The terminal will continue to be delivered as part of the quarterly Simultaneous Release of Eclipse as well.

The marketplace entry[4] had not been updated in a few years. It will once again install the latest release of the terminal on the latest release of the whole IDE (currently 2020-03).

If this bug is no longer relevant, please feel free to comment or close the bug. If you can confirm if this issues still occurs in the latest release please do let me know in a comment.

[1] https://wiki.eclipse.org/CDT/User/NewIn911
[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git (in the terminal directory)
[3] current release is 9.11 - P2 site https://download.eclipse.org/tools/cdt/releases/9.11/
[4] https://marketplace.eclipse.org/content/tm-terminal

(This comment was added to all open terminal bugs along with changing the Product/component pair to CDT/terminal.)
Comment 6 Jonah Graham CLA 2020-05-18 11:52:59 EDT
*** Bug 453696 has been marked as a duplicate of this bug. ***
Comment 7 Jonah Graham CLA 2021-05-19 12:55:49 EDT
(In reply to Martin Oberhuber from Bug 460495 comment #2)
> Also, when 2 terminal instances are open, after a File > Restart all
> terminal are restored in the secondary instance.
> 
> Expected: Terminals should be restored in the instance in which they were
> open previously. Otherwise the screen layout is destroyed, causing more
> annoyance than value.

This split into Bug 573646.
Comment 8 Jonah Graham CLA 2021-05-19 12:58:10 EDT
(In reply to Martin Oberhuber from Bug 460495 comment #4)
> This is currently one of the most annoying issues in Terminal, code
> contributions would be most welcome !
> 
> As a first step, I'm fine if only the "startup directory" of any terminal is
> restored on restart.

Split into Bug 453696 for this aspect.
Comment 9 Jonah Graham CLA 2021-05-19 12:59:57 EDT
This bug is now just about preserving the shell to use.
Comment 10 Eclipse Genie CLA 2021-05-19 13:19:25 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180787
Comment 12 Jonah Graham CLA 2021-05-19 15:01:46 EDT
Done, with an entry added to N&N https://wiki.eclipse.org/CDT/User/NewIn103#Terminal