Community
Participate
Working Groups
org.eclipse.php.internal.ui.preferences.FoldingConfigurationBlock#performOk() changes the SSE UI folding preference. This is not meant for other plug-ins to modify. A request to make the setting variable by content type would have been preferred.
It's not possible now. SSE control folding by global settings in General -> Structured Text Editors. 1. StructuredTextEditor have hardcoded combined preference store 2. FoldingActionGroup is also hardcoded to SSE preferences only Because I currently working on reducing StructuredTextEditor overrides via bug 558940 (our editor in previous release had more code) I'll be happy if: 1. Could we install own preference store in "StructuredTextEditor.createCombinedPreferenceStore" 2. Use same preference store in FoldingActionGroup
Let me see if there's something we can delegate using the at-runtime configuration targets.
Created attachment 281842 [details] first draft, still needs more refactoring Attaching an in-progress patch of how I think this could work in the future. The preference page itself needs to be broken out into separate Appearance and Hovers pages that can be publicly referenced and reused, and some thought put into how to intelligently pull default values, but then this should aim to be as simple as parameterizing the preference node name on both the org.eclipse.ui.editors and org.eclipse.ui.preferencePage extensions. That, or borrow the way annotation preferences work. Anyway, just looking for feedback on the approach, particularly to the sample changes made in the plugin.xml of an editor plug-in.
(In reply to Nitin Dahyabhai from comment #3) > Created attachment 281842 [details] > first draft, still needs more refactoring Amazing, looks interesting. It open opportunity to personalize PHP Editor in more civilized way ;) As I mentioned before, FoldingActionGroup will also require refactoring similar to StructuredTextEditor.createCombinedPreferenceStore
(In reply to Dawid Pakula from comment #4) Refactored and in for M1.
New Gerrit change created: https://git.eclipse.org/r/161372
Gerrit change https://git.eclipse.org/r/161372 was merged to [master]. Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=fc0aa936d0b02e39f6a0f1e15abda79ddff9e31c
Fixed in HEAD. Thank you for cooperation ;)
How I can Install PDT after fix this bug? Commit: https://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=fc0aa936d0b02e39f6a0f1e15abda79ddff9e31c It is need org.eclipse.wst.sse.ui 1.7.0 which not exists even in Eclipse 2020-06. Here 1.6.3 only.
Add this repository to eclipse: https://download.eclipse.org/webtools/downloads/drops/R3.18.0/I-latest/repository/
Thank you. Worked.
