Bugzilla will undergo maintenance 2024-03-29 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 573512 - Missing "remove project" option in org.eclipse.cdt.managedbuilder.internal.core.HeadlessBuilder
Summary: Missing "remove project" option in org.eclipse.cdt.managedbuilder.internal.c...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build-managed (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 10.3.0   Edit
Assignee: Marc Siebenhaar CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-12 19:38 EDT by Marc Siebenhaar CLA
Modified: 2021-05-17 14:45 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Siebenhaar CLA 2021-05-12 19:38:03 EDT
Based on the function for adding projects to the workspace, it can also be desirable and necessary to remove projects from workspace.
Comment 1 Jonah Graham CLA 2021-05-12 21:10:56 EDT
Sounds like a good idea and I look forward to the contribution. At the risk of feature creep - removing by project name or file path makes sense, also a -removeAll would also make sense I suspect?

=====

I saw your PR on GitHub https://github.com/eclipse-cdt/cdt/pull/18/ - as you have closed it you probably realized that we don't currently take GitHub PRs. Our contribution flow is via gerrit: https://wiki.eclipse.org/CDT/contributing. You have already signed the ECA, so all that is needed is to push your change to gerrit.

Please feel free to ask questions if you need help getting started.
Comment 2 Marc Siebenhaar CLA 2021-05-13 04:52:44 EDT
Thanks for your fast response.
I have problems to login to gerrit with my bugzilla account (https://git.eclipse.org/r) for creating the branch.

I am realy confused about this...
Comment 3 Marc Siebenhaar CLA 2021-05-13 05:15:36 EDT
After a bit research, I run into the same problem as the users in this threads:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565176
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565060
Comment 4 Jonah Graham CLA 2021-05-13 06:41:58 EDT
Hi Marc, sorry that you have a problem with your account. I have asked webmaster for help in Bug 573520.
Comment 5 Eclipse Genie CLA 2021-05-13 19:08:27 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180587
Comment 6 Marc Siebenhaar CLA 2021-05-13 19:16:43 EDT
Changes are commited but there is a merge conflict with a changeset from 2018 (Bug 540622)...? Should I have to handle anything there?
Comment 7 Jonah Graham CLA 2021-05-13 22:05:06 EDT
(In reply to Marc Siebenhaar from comment #6)
> Changes are commited [...]
Great. I am glad your account is working now.

> [...] but there is a merge conflict with a changeset from
> 2018 (Bug 540622)...? Should I have to handle anything there?

No - you can ignore that. Thanks for checking!

As this item looks pretty close to completion I think we should have no trouble getting it into CDT 10.3.0. The effective deadline for that is 31 May.
Comment 8 Eclipse Genie CLA 2021-05-14 04:50:16 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180596
Comment 9 Eclipse Genie CLA 2021-05-14 14:38:14 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180612
Comment 10 Eclipse Genie CLA 2021-05-14 16:57:02 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180616
Comment 11 Eclipse Genie CLA 2021-05-14 17:03:14 EDT
New Gerrit change created: https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/180618
Comment 14 Jonah Graham CLA 2021-05-15 17:59:22 EDT
Thank you Marc for this improvement.

All that is left now is to announce the new feature in CDT's New and Noteworthy. https://wiki.eclipse.org/CDT/User/NewIn103

Can you please create an entry for this improvement? You may get moderated on your first edit - if so, please ping me here and I will be able to mark you as not a spammer (I don't get notified of moderated edits otherwise).
Comment 15 Marc Siebenhaar CLA 2021-05-17 14:07:02 EDT
Ok. Should i add this new Feature under "Build", "Terminal" or "API modifications" ?
Comment 16 Jonah Graham CLA 2021-05-17 14:25:03 EDT
I think Build is best.
Comment 17 Marc Siebenhaar CLA 2021-05-17 14:39:13 EDT
Nevermind, I add it under "build" like the change in headless builder in 10.2.
You can now unlock the moderated change.
Comment 18 Jonah Graham CLA 2021-05-17 14:44:58 EDT
(In reply to Marc Siebenhaar from comment #17)
> You can now unlock the moderated change.

Done. Your changes should not be moderated going forward.
Comment 19 Jonah Graham CLA 2021-05-17 14:45:19 EDT
Thanks Marc for the improvement!