Community
Participate
Working Groups
Currently, AbstractAdviceBindingConfiguration are specified at the root of the ElementTypeSet, and must reference the corresponding ElementType(s). In most case, custom Advices (Especially the ones related to Stereotypes, which is what we care about in the generated ElementTypes models) are related to a single ElementType, so having them in a flat structure is error-prone. The ElementTypesConfigurations model should allow defining AbstractAdviceBindingConfiguration as children of ElementTypeConfiguration (In addition to the current reference mechanism: it doesn't replace it). Some challenges about this: - Compatibility with existing ElementTypesConfiguration models must be preserved - When an AbstractAdviceBindingConfiguration is defined as a child of an ElementTypesConfiguration, some of its attributes will become irrelevant; especially the "target" reference (Which should always be the parent ElementType in this case), and the newly added "Apply to all types" attribute (Which should be false in this case). Ideally, these attributes would not exist at all for AbstractAdviceBindingConfiguration owned by their element type. It may be difficult to adjust the metamodels for this; so alternatively, we can either automatically set these values, or add a validation rule to detect/avoid/fix inconsistencies. - The infra.types (meta)model is extended by UML-specific metamodels (especially uml.types.core); we need to make sure such extensions remain consistent with the updated metamodel
Created attachment 284757 [details] Sibling advice example Here's an example of a generated ElementTypeSetConfiguration, where the advice is separated from its type. We want to make it possible to define the selected Advice as a child element of the selected Type
This task should cover the metamodels update, as well as the necessary runtime updates (So Advice Configurations defined as child element of Element Types should be properly registered/taken into account). This task doesn't include changes to the Element Types generation, or builders/validators for these models.
The Gerrit patch 172390 (cf. See Also field) is merged to the bugs/568494-toolsmiths-dev branch.
Fixed on the bugs/568494-toolsmiths-dev branch
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178168
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178170
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178171
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178172
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178176
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178173
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178174
New Gerrit change created: https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178175
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178168 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=9c674218a4c474ce6166c694819682ef1b4052ba
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178170 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=dfc8741abf281e8c67114e0031f9809d4bba0271
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178171 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=355a1235671a5274ac47774c0dacd63aedbecf57
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178172 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=6b045d55b602809cb444630409e8d47b3af83b42
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178173 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=64b9c37eedc2f57ab0b9f6e44a6c9baf02dba066
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178174 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=de5c830be2b4b73931cfe0c7fee53e081d24b123
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178175 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=0780dc0708669bfaf5d3b4aacef8f22ba3bb8a4f
Gerrit change https://git.eclipse.org/r/c/papyrus/org.eclipse.papyrus/+/178176 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=bb8d6dd9c816ca972049d03334bf9b5c9c18df31