Bug 560450 - Retire LegacyJavadocCompletionProposalComputer
Summary: Retire LegacyJavadocCompletionProposalComputer
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.16 M1   Edit
Assignee: Lars Vogel CLA
QA Contact: Roland Grunberg CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-24 04:10 EST by Lars Vogel CLA
Modified: 2020-04-07 11:06 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-02-24 04:10:34 EST 
LegacyJavadocCompletionProposalComputer has not been touched since 2005. I suggest to evaluate if it can be deleted.
Comment 1 Eclipse Genie CLA 2020-02-24 04:11:50 EST 
New Gerrit change created: https://git.eclipse.org/r/158204
Comment 2 Roland Grunberg CLA 2020-03-16 12:32:07 EDT 
LegacyJavadocCompletionProposalComputer#computeProposals() basically ends up calling getContributedProcessors(), which looks for extensions to 'org.eclipse.jdt.ui.javadocCompletionProcessor'

https://github.com/eclipse/eclipse.jdt.ui/blob/master/org.eclipse.jdt.ui/schema/javadocCompletionProcessor.exsd

"Deprecated as of 3.2. Extenders should rather contribute to the <tt>org.eclipse.jdt.ui.javaCompletionProposalComputer</tt> extension point, which allows to provide additional proposals not only for javadoc, but any part of a Java editor."

To be safe I think we should just confirm it's generally returning an empty list, and then see if anything in simrel actually makes use of it.
Comment 3 Roland Grunberg CLA 2020-03-17 13:44:56 EDT 
We should probably stick to just LegacyJavadocCompletionProposalComputer as it's non-API.

From what I can tell LegacyJavadocCompletionProposalComputer is always returning an empty list in a regular Eclipse SDK and I couldn't find anything that contributes to the extension point or uses IJavadocCompletionProposal in releases/2020-03 that would cause its return to be non-empty.
Comment 4 Lars Vogel CLA 2020-03-17 14:09:55 EDT 
(In reply to Roland Grunberg from comment #3)
> We should probably stick to just LegacyJavadocCompletionProposalComputer as
> it's non-API.

I assume you mean that we should not yet delete the schema. Fine for me, I would suggest to do this as a separate step.

> From what I can tell LegacyJavadocCompletionProposalComputer is always
> returning an empty list in a regular Eclipse SDK and I couldn't find
> anything that contributes to the extension point or uses
> IJavadocCompletionProposal in releases/2020-03 that would cause its return
> to be non-empty.

So the Gerrit is fine in its current form?
Comment 6 Roland Grunberg CLA 2020-04-07 11:06:11 EDT 
Verified for 4.16 M1 using I20200407-0120 build