Bug 551066 - [Reveal Service] Revealing a control does not work within a category
Summary: [Reveal Service] Revealing a control does not work within a category
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.22.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.23.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-13 16:44 EDT by Christian Damus CLA
Modified: 2019-10-14 04:06 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2019-09-13 16:44:41 EDT
In a categorization rendered as a tree, only the selected category's view is actually rendered.  For any other category in the tree, its view is not rendered and if it was rendered, then those controls (and renderers) were disposed when the selection was changed.  Consequently, navigation of a marker that should reveal a specific feature's control will not work if that control is in a category that is not selected.

Steps to reproduce:

1. Create a view model with a Categorization rendered as a tree.
2. In the editor, select a category that is not the default category selection
   and make some validation error in some control in that category's view.
3. Change the category selection to some other category.
4. Find thee marker validation problem from step 2 (in the errors view or
   diagnostic view) and double-click to navigate, assuming that your editor
   connected the go-to-marker protocol with the Reveal Service.
5. See that nothing happens and the editor remains as it was in step 4.
   This is because at step 3 the view (and controls) in which the error was made
   in step 2 were disposed.
Comment 1 Eclipse Genie CLA 2019-09-14 09:37:15 EDT
New Gerrit change created: https://git.eclipse.org/r/149528
Comment 3 Christian Damus CLA 2019-09-16 07:26:27 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/149528 was merged to [develop].
Comment 4 Christian Damus CLA 2019-09-27 07:14:48 EDT
Fixpublished in the 1230_201909261922 build.
Comment 5 Jonas Helming CLA 2019-10-14 03:54:01 EDT
Shouldnt we mark this with "test" as it might reveal new stuff in the UI?
Comment 6 Eugen Neufeld CLA 2019-10-14 04:06:27 EDT
In my opinion we don't need the test flag as we fixed a bug, but I don't mind having it either