Community
Participate
Working Groups
It would be nice to be able to perform inline resource renaming from the Project Explorer. Are there any cases for non-Java resources where the dialog (Rename Wizard) *must* be present? Ideally, the dialog should only appear in those scenarios.
New Gerrit change created: https://git.eclipse.org/r/145320
New Gerrit change created: https://git.eclipse.org/r/146672
New Gerrit change created: https://git.eclipse.org/r/146673
Gerrit change https://git.eclipse.org/r/146673 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=85b5b5ab06bc338b24d32928f3e5f631023c2c54
Gerrit change https://git.eclipse.org/r/145320 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c53f80ba4e55e3ffd7b758f4cc61ec75a948d653
Thanks Andrew. Please add a note about it in the noteworthy doc.
(In reply to Mickael Istria from comment #6) > Thanks Andrew. > Please add a note about it in the noteworthy doc. Of course :)
New Gerrit change created: https://git.eclipse.org/r/147146
New Gerrit change created: https://git.eclipse.org/r/147152
Gerrit change https://git.eclipse.org/r/147152 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d9565885047e4a69fe4fc5a4497e8cff7ec2e8d5
Thanks Andrew!
(In reply to Mickael Istria from comment #11) > Thanks Andrew! Thanks also from my side. AFAICS JDT still uses the dialog approach. Any plans to support this inline edit also for .java files? Could be similar to the refactoring in JDT which allows to rename the file inline and if desire to open a dialog which more options.
(In reply to Lars Vogel from comment #12) > AFAICS JDT still uses the dialog approach. Any plans to support this inline > edit also for .java files? Could be similar to the refactoring in JDT which > allows to rename the file inline and if desire to open a dialog which more > options. JDT rename handler would need to be reworked. Please open a new ticket for that.
(In reply to Mickael Istria from comment #13) > JDT rename handler would need to be reworked. > Please open a new ticket for that. Bug 549873.
New Gerrit change created: https://git.eclipse.org/r/149589
New Gerrit change created: https://git.eclipse.org/r/149590
New Gerrit change created: https://git.eclipse.org/r/149593
Attached Gerrit patches to revert only the Platform UI part of the fix on master and R4_13_maintenance. Also, removed the online N&N entry from 4.13 news repo.
Gerrit change https://git.eclipse.org/r/149589 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c99322eec70b19200e9b8dbc9e45f2b25e751fdb
Gerrit change https://git.eclipse.org/r/149590 was merged to [R4_13_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a7975082f940e577c1ebb82439ba61d3b7e31673
Gerrit change https://git.eclipse.org/r/149593 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8135cf3c85070c352064cdfd7719bbbcfe2b8d82
Note for the next implementation attempt: please see bug 550560 and especially bug 550560 comment 3. *If* we want bring inline rename to Eclipse, a precondition is that this should *improve* user experience. As of today, the new feature fails to reduce number of clicks/actions required to achieve "rename" use case, in fact it actually *increases* this number and also surprises the user by opening dialog box after inline rename was confirmed via "enter". I have no solutions, but I have clear understanding what it should deliver: F2 -> type new name -> enter => done. No extra dialogs / actions / clicks after "enter". So bug 550560 is a blocking one for this feature.
> I have no solutions, but I have clear understanding what it should deliver: > F2 -> type new name -> enter => done. No extra dialogs / actions / clicks > after "enter". So bug 550560 is a blocking one for this feature. Dialog is OK for me but then I don't want to get into inline editing before.
Depends on Bug 543747, see Bug 550857 Comment 25 If https://git.eclipse.org/r/150661 is reverted then Bug 543747 will probably no longer affect this.
Removed milestone as no one reacted to https://www.eclipse.org/lists/eclipse-dev/msg11217.html.
@Andrew: I think we're done here. Can you please (re)create the N&N entry?
(In reply to Mickael Istria from comment #26) > @Andrew: I think we're done here. Can you please (re)create the N&N entry? For sure, will get to it as soon as possible.
