Bug 545761 - White space before closing parenthesis not working in methods with default arguments
Summary: White space before closing parenthesis not working in methods with default ar...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-25 14:37 EDT by Ariel Kempf CLA
Modified: 2020-05-14 11:24 EDT (History)
1 user (show)

See Also:

Attachments
PDT formatter bug closing parenthesis in methods with default argument (17.28 KB, image/png)
2019-03-25 14:37 EDT, Ariel Kempf CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariel Kempf CLA 2019-03-25 14:37:08 EDT 
Created attachment 277998 [details]
PDT formatter bug closing parenthesis in methods with default argument

Going in "White Spaces" tab, then in "Declarations/Methods" and checking "before closing parenthesis" does not work if methods end with a default argument.

The "Preview" section even has an exemple of this behavior (see attachment).
Selecting/unselecting the option has no effect on the preview pane.
Code does not get correctly formatted either.
Comment 1 Ariel Kempf CLA 2019-03-25 14:38:50 EDT 
Forgot to mention: was using Eclipse 2018-09 with the PDT from that time.
Upgraded PDT to 6.2 and Eclipse to 2019-03 and nothing changed.
Comment 2 Eclipse Genie CLA 2019-04-05 04:59:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/140093
Comment 4 Thierry BLIND CLA 2019-04-05 06:06:19 EDT 
Hi Ariel,
thank you for your very concise and useful bug report.
Should be fixed now.

Thierry.