Bug 544116 - [Table] Inefficient table updates for validation changes
Summary: [Table] Inefficient table updates for validation changes
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: Validation (show other bugs)
Version: 1.19.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.20.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-04 16:03 EST by Christian Damus CLA
Modified: 2019-02-19 07:47 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2019-02-04 16:03:06 EST
For very large tables (more than 10000 objects), the performance of selection is so slow (on the order of seconds to stabilize the UI thread) as to make keyboard navigation from row to row unusable.

The problem is that, even though now the validation performed on selection change is scoped to the specific child context (per bug 543190), the applyValidation() callback in the table renderer is implemented to update every row of the table.  There is an alternative API that should let the renderer update only objects whose validation status is changed.
Comment 1 Eclipse Genie CLA 2019-02-04 18:04:39 EST
New Gerrit change created: https://git.eclipse.org/r/136266
Comment 3 Christian Damus CLA 2019-02-05 09:16:00 EST
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/136266 was merged to [develop].
Comment 4 Christian Damus CLA 2019-02-19 07:47:37 EST
The fix is now published in the 1.20 RC1 build.