542839 – Extract the diagram synchronization logic

Bug 542839 - Extract the diagram synchronization logic

Summary: Extract the diagram synchronization logic

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	6.1.0
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	6.2.0
Assignee:	Pierre-Charles David
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2018-12-17 03:22 EST by Pierre-Charles David
Modified:	2019-04-01 05:51 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pierre-Charles David

2018-12-17 03:22:41 EST

The DDiagramSynchronizer and related classes are complex and tightly coupled to the details of the DDiagram data structure. It should be possible to extract/abstract the core algorithm underneath to make as much of it as possible retargetable to the web flavor.

Comment 1 Pierre-Charles David

2019-01-28 03:22:02 EST

I've spent some time analysing the concerned code and its dependencies, and the conclusion is that it would be much too complex/costly and risky to attempt this. I leave the ticket in the scope of 6.2 because as part of the analysis I have made a few small cleanup patches that could be merged, but the initial scope is WONTFIX.

Comment 2 Eclipse Genie

2019-01-29 09:07:09 EST

New Gerrit change created: https://git.eclipse.org/r/135940

Comment 3 Eclipse Genie

2019-01-29 09:07:11 EST

New Gerrit change created: https://git.eclipse.org/r/135945

Comment 4 Eclipse Genie

2019-01-29 09:07:12 EST

New Gerrit change created: https://git.eclipse.org/r/135944

Comment 5 Eclipse Genie

2019-01-29 09:07:14 EST

New Gerrit change created: https://git.eclipse.org/r/135943

Comment 6 Eclipse Genie

2019-01-29 09:07:15 EST

New Gerrit change created: https://git.eclipse.org/r/135942

Comment 7 Eclipse Genie

2019-01-29 09:07:17 EST

New Gerrit change created: https://git.eclipse.org/r/135941

Comment 8 Eclipse Genie

2019-01-29 09:07:18 EST

New Gerrit change created: https://git.eclipse.org/r/135947

Comment 9 Eclipse Genie

2019-01-29 09:07:20 EST

New Gerrit change created: https://git.eclipse.org/r/135950

Comment 10 Eclipse Genie

2019-01-29 09:07:21 EST

New Gerrit change created: https://git.eclipse.org/r/135949

Comment 11 Eclipse Genie

2019-01-29 09:07:22 EST

New Gerrit change created: https://git.eclipse.org/r/135948

Comment 12 Eclipse Genie

2019-01-29 09:07:24 EST

New Gerrit change created: https://git.eclipse.org/r/135951

Comment 13 Eclipse Genie

2019-01-29 09:07:25 EST

New Gerrit change created: https://git.eclipse.org/r/135946

Comment 14 Eclipse Genie

2019-02-05 08:06:58 EST

Gerrit change https://git.eclipse.org/r/135950 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b11cef5a810444402844652c5826fd74eef709bd

Comment 15 Eclipse Genie

2019-02-05 08:06:59 EST

Gerrit change https://git.eclipse.org/r/135947 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3622a65ee0c9a9d318993b87389d6d4cdac52bd0

Comment 16 Eclipse Genie

2019-02-05 08:07:02 EST

Gerrit change https://git.eclipse.org/r/135948 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c9cb6e88837774e2a5ec15ccd053a2887ff7fca4

Comment 17 Eclipse Genie

2019-02-05 08:07:03 EST

Gerrit change https://git.eclipse.org/r/135949 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c859f2cf2d16131df470c3b13c8e776e9b9bf176

Comment 18 Eclipse Genie

2019-02-05 08:07:05 EST

Gerrit change https://git.eclipse.org/r/135944 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a2fdbc30ee916a082f2d4911c6b37f9c8b07a043

Comment 19 Eclipse Genie

2019-02-05 08:07:07 EST

Gerrit change https://git.eclipse.org/r/135945 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c58de777c1cfcbab3c9f6309d747405d1d926173

Comment 20 Eclipse Genie

2019-02-05 08:07:09 EST

Gerrit change https://git.eclipse.org/r/135946 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bdf78e3a64014b62e65072a901036ccf6b2fe9a4

Comment 21 Eclipse Genie

2019-02-05 08:07:10 EST

Gerrit change https://git.eclipse.org/r/135941 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=012f8f21be74df7b61d7d9d95373fd47f9cdcfc3

Comment 22 Eclipse Genie

2019-02-05 08:07:12 EST

Gerrit change https://git.eclipse.org/r/135942 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2aaf827e3ccdfcf88fd6a874673cc897ccdd7d1d

Comment 23 Eclipse Genie

2019-02-05 08:07:15 EST

Gerrit change https://git.eclipse.org/r/135943 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=22c681ef136f28c4462210061896ec573089a6e4

Comment 24 Eclipse Genie

2019-02-05 08:07:17 EST

Gerrit change https://git.eclipse.org/r/135940 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=cafe4ee18279a95fb1c8c413d914965cc7e599b0

Comment 25 Pierre-Charles David

2019-02-07 09:03:17 EST

Marking as RESOLVED, even though what was merged are just simple cleanups. As mentioned in a previous comment the initial scope was abandonned as too costly and risky.

Comment 26 Pierre-Charles David

2019-02-21 02:48:38 EST

This is purely internal/technical change. The automated tests have not shown any related regression since this was merged, so marking as VERIFIED.

Comment 27 Pierre-Charles David

2019-04-01 05:51:45 EDT

Available in Sirius 6.2.0, see https://wiki.eclipse.org/Sirius/6.2.0 for details.