Bug 537608 - PHP 7.3 Support
Summary: PHP 7.3 Support
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 543098
Blocks:
  Show dependency tree
 
Reported: 2018-08-02 08:56 EDT by Dawid Pakula CLA
Modified: 2020-05-14 10:16 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2018-08-02 08:56:36 EDT 
PHP 7.3 is now in beta 1 stage (no more features). 

Major changes that might affect PDT:
1. Support for trailing comma in function/method calls (without headers) similar to array declarations https://wiki.php.net/rfc/trailing-comma-function-calls
2. Indentation support in HEREDOC/NOWODOC https://wiki.php.net/rfc/flexible_heredoc_nowdoc_syntaxes
3. References in list() https://wiki.php.net/rfc/list_reference_assignment
4. instanceof now allows literals as the first operand,
in which case the result is always FALSE

See UPGRADING file : https://github.com/php/php-src/blob/PHP-7.3/UPGRADING
Comment 1 Eclipse Genie CLA 2018-11-01 13:14:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/131811
Comment 2 Thierry BLIND CLA 2018-11-06 09:56:03 EST 
Hi Dawid,
my patch implements point 2 (indentation support in HEREDOC/NOWODOC), the biggest  (and most intrusive) syntax change.

In the past, I've already implemented support for "trailing comma in function/method calls" in PHP 7.2, I haven't seen that this feature was finally delayed by Zend for PHP 7.3!
So PDT already supports this syntax, maybe we should move that from PHP 7.2 to PHP 7.3, I don't know...

For point 3 and 4, is there something to do on PDT side?
Comment 4 Thierry BLIND CLA 2018-11-13 05:13:50 EST 
The 2 major features (point 1 and 2) should be implemented.
I don't know if point 3 and 4 need some changes in PDT, so I keep this bug report open for now.
Dawid, feel free to close it if you think we're done here.
Comment 5 Thierry BLIND CLA 2018-11-13 05:17:51 EST 
> The 2 major features (point 1 and 2) should be implemented.
Wrong formulation: point 1 and 2 are (of course) implemented now ;)
Comment 6 Dawid Pakula CLA 2019-07-09 10:10:18 EDT 
Everything it's working fine. Marking as fixed.

Thank You Thierry!