535024 – Translated JTAG device names causes launch failures with shared launch configurations

Bug 535024 - Translated JTAG device names causes launch failures with shared launch configurations

Summary: Translated JTAG device names causes launch failures with shared launch config...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-other (show other bugs)
Version:	9.5.0
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	9.5.0
Assignee:	Torbjörn Svensson
QA Contact:	Doug Schaefer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2018-05-23 11:28 EDT by Torbjörn Svensson
Modified:	2018-06-27 05:14 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Torbjörn Svensson

2018-05-23 11:28:18 EDT

The name of the JTAG device is saved in the active UI language within the launch configuration file. This makes it impossible to translate the names of the JTAG devices and share the launch configuration between different eclipse environments. Since each JTAG device has an id, this should be the key to finding the JTAG device rather than the "volatile" name.

Comment 1 Eclipse Genie

2018-05-23 11:31:36 EDT

New Gerrit change created: https://git.eclipse.org/r/123186

Comment 2 Torbjörn Svensson

2018-05-23 11:34:46 EDT

The proposed solution is backward compatible, so if the new attribute does not exist, it tries to use the old one to look up the JTAG device to use for the launch.

Comment 3 Jonah Graham

2018-05-23 15:57:37 EDT

(In reply to TorbjÃ¶rn Svensson from comment #2)
> The proposed solution is backward compatible, so if the new attribute does
> not exist, it tries to use the old one to look up the JTAG device to use for
> the launch.

I like how you have designed it to be backwards compatible. But API changes after M7 needs approval. I have asked John to review as he is the committer in CDT most familiar with JTAG.

Comment 4 Torbjörn Svensson

2018-05-24 04:05:26 EDT

(In reply to Jonah Graham from comment #3)
> I like how you have designed it to be backwards compatible. But API changes
> after M7 needs approval. I have asked John to review as he is the committer
> in CDT most familiar with JTAG.

Ok, thanks.

Comment 5 Eclipse Genie

2018-05-24 16:49:34 EDT

Gerrit change https://git.eclipse.org/r/123186 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=a7b0a1fe806fa248e8e2c497f144177244e8f7e4

Comment 6 John Dallaway

2018-05-24 16:58:10 EDT

Thank you for the contribution, Torbjörn.

Comment 7 Eclipse Genie

2018-05-26 08:52:57 EDT

New Gerrit change created: https://git.eclipse.org/r/123382

Comment 8 Eclipse Genie

2018-05-26 17:11:38 EDT

Gerrit change https://git.eclipse.org/r/123382 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=35b4bf02de354d0ec7d4ae3f96cc3951218a5ffb

Comment 9 Jonah Graham

2018-06-27 04:57:39 EDT

(In reply to John Dallaway from comment #6)
> Thank you for the contribution, Torbjörn.

John, is there anything left to this bug? If not can you mark RESOLVED.

Comment 10 Jonah Graham

2018-06-27 05:14:50 EDT

(In reply to Jonah Graham from comment #9)
> (In reply to John Dallaway from comment #6)
> > Thank you for the contribution, Torbjörn.
> 
> John, is there anything left to this bug? If not can you mark RESOLVED.

AFAICT this is done, if I got this wrong, please reopen.