Bug 534544 - Image allocated by PHPEditorErrorTickUpdater never disposed and stored forever in dltk image registry
Summary: Image allocated by PHPEditorErrorTickUpdater never disposed and stored foreve...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2018-05-10 11:26 EDT by Dawid Pakula CLA
Modified: 2020-05-14 10:16 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2018-05-10 11:26:50 EDT 
Via this class PDT set editor image decorated with information about errors. This image is never disposed or reused.

This class create own ScriptUILabelProvider. It trying to reuse original registry, but because internal StorageLabelProvider it's always fresh, it recreate file images each time. As the result DLTK ImageRegistry is growing....

As the result we have leak in two places:
1. Java
2. SWT resources
Comment 1 Eclipse Genie CLA 2018-05-10 18:01:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/122447