Bug 534520 - Documentation dialog is light on dark theme
Summary: Documentation dialog is light on dark theme
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 14:19 EDT by Michal Niewrzal CLA
Modified: 2020-05-14 13:25 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (217.52 KB, image/png)
2018-05-09 14:19 EDT, Michal Niewrzal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2018-05-09 14:19:06 EDT 
Created attachment 273984 [details]
screenshot

See screenshot.

PDT: latest nightly
OS: Fedora 27
Comment 1 Lars Vogel CLA 2018-06-22 04:53:43 EDT 
Is this still an issue in PHP? For JDT this was fixed.
Comment 2 Dawid Pakula CLA 2018-06-22 04:56:49 EDT 
Unfortunately yes.
Comment 3 Lars Vogel CLA 2018-06-22 05:10:19 EDT 
(In reply to Dawid Pakula from comment #2)
> Unfortunately yes.

Does the JDT implementation help you? http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=c985435da10b09c41abffd94f75bd9ee2131bb46

See Bug 508901 and Bug 517393 for a longer version.
Comment 4 Dawid Pakula CLA 2018-06-22 05:27:38 EDT 
(In reply to Lars Vogel from comment #3)
> (In reply to Dawid Pakula from comment #2)
> > Unfortunately yes.
> 
> Does the JDT implementation help you?
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/
> ?id=c985435da10b09c41abffd94f75bd9ee2131bb46
> 
> See Bug 508901 and Bug 517393 for a longer version.

Yes, DLTK is mostly JDT fork so should be easy to port this into it, PDT and other adopters will handle benefit ;)

Thanks
Comment 5 Eclipse Genie CLA 2018-06-22 11:00:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/124901
Comment 6 Eclipse Genie CLA 2018-06-22 11:03:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/124902