534273 – The go to marker creates a new Sirius session

Bug 534273 - The go to marker creates a new Sirius session

Summary: The go to marker creates a new Sirius session

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	4.1.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	6.0.0
Assignee:	Laurent Redor
QA Contact:	Guillaume Coutable

URL:
Whiteboard:
Keywords:	triaged

Depends on:	509300 509970
Blocks:
	Show dependency tree

Reported:	2018-05-02 12:40 EDT by Laurent Redor
Modified:	2018-06-27 11:55 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2018-05-02 12:40:19 EDT

+++ This bug was initially created as a clone of Bug #509970 +++

When performing a go to marker, the DDiagramEditorImpl.getCorrectInput translates the FIleEditorInput into SessionEditorInput. But the method org.eclipse.sirius.ui.business.api.session.SessionEditorInput.create(URI) creates a new Sirius Session from the session resource URI each time the go to marker is executed. Those sessions are never closed.

Comment 1 Eclipse Genie

2018-05-03 09:44:14 EDT

Gerrit change https://git.eclipse.org/r/87258 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2fad1fe095837aae343d439ddc618c5eb679d034

Comment 2 Guillaume Coutable

2018-05-24 11:30:28 EDT

Validated with Sirius 6.0M7

Comment 3 Laurent Redor

2018-06-27 11:55:16 EDT

Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details