Bug 533854 - Add a note tool that allows to reference other representations
Summary: Add a note tool that allows to reference other representations
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 enhancement (vote)
Target Milestone: 6.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Laurent Redor CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2018-04-20 04:25 EDT by Steve Monnier CLA
Modified: 2018-06-27 11:54 EDT (History)
3 users (show)

See Also:


Attachments
SimpleModelingProject.zip (3.56 KB, application/x-zip-compressed)
2018-05-29 09:42 EDT, Laurent Redor CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Monnier CLA 2018-04-20 04:25:50 EDT
Report of bugzilla 533002 on the master branch.
Comment 1 Eclipse Genie CLA 2018-04-20 07:25:47 EDT
New Gerrit change created: https://git.eclipse.org/r/121466
Comment 2 Steve Monnier CLA 2018-04-20 10:16:06 EDT
Enhancement reported on the master branch
Comment 4 Steve Monnier CLA 2018-04-20 10:20:32 EDT
The validation scenario is available on bugzilla 533002
Comment 5 Eclipse Genie CLA 2018-04-27 10:49:48 EDT
New Gerrit change created: https://git.eclipse.org/r/121872
Comment 7 Eclipse Genie CLA 2018-05-02 10:35:54 EDT
New Gerrit change created: https://git.eclipse.org/r/122027
Comment 9 Laurent Redor CLA 2018-05-28 09:47:30 EDT
During homologation of this issue, I noticed 2 points:
1- There is nothing in the release notes that talk about this new feature.
2- It seems that a problem can appears if a diagram with a link to a removed diagram is in read only. I will attach a steps to reproduce, but it my case, the link displayed the name of the diagram containing the link and not "nothing".
Comment 10 Laurent Redor CLA 2018-05-29 09:42:39 EDT
Created attachment 274241 [details]
SimpleModelingProject.zip

Steps to reproduce for the above problem:

* Import SimpleModelingProject (from SimpleModelingProject.zip)
* Set preferences "Do refresh on representation opening" and "Automatic refresh" to false
* Open diagram "p1Diagram"
* Delete class "C11FromP1" (use "Delete From Model" action of the tabbar)
* Save
* Open diagram "p2Diagram"
* OK: The node representing class "C11FromP1" is always here but with a red cross. This is expected as we are in manual refresh.
* Close diagram "p2Diagram"
* Delete diagram "p1Diagram"
* Open diagram "p2Diagram"
* KO: The Link Note pointing to the deleted diagram displays "p2Diagram" instead of "blank" in normal case
Comment 11 Laurent Redor CLA 2018-05-29 10:20:28 EDT
The cause of the above problem is certainly bug 412078.
This problem does not exist if Sirius is used with "team" as the Sirius CDO Native version of ViewImpl contains an adaptation to handle this case.
Comment 12 Eclipse Genie CLA 2018-05-29 11:54:32 EDT
New Gerrit change created: https://git.eclipse.org/r/123544
Comment 13 Laurent Redor CLA 2018-05-29 11:56:28 EDT
There is also another problem when a target diagram of a "Link Note" is deleted. See explanation on cloned issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=533002#c30
Comment 15 Steve Monnier CLA 2018-05-29 12:04:42 EDT
I merged https://git.eclipse.org/r/#/c/123544/ that updated the release note about this new feature.
Comment 16 Laurent Redor CLA 2018-06-07 08:57:28 EDT
As for cloned issue, bug 533002, issues have been created to all problems detected during the validation phase. They are not considered as blocking and will be fixed in further version:
* bug 535648 - Improve "Link Note" delete lifecycle
* bug 535649 - Wrong representation name displayed in "Link Note" if targeted representation is deleted
* bug 535651 - "Link Note" must be available only on diagram or on container
* bug xxxxxx - Change the name of this tool - No issue has been created for that but it is possible that this tool will be renamed

These bugzillas correspond to issue probably fixed in Sirius 5.1.x and then reported to Sirius 6.0.x
Comment 17 Laurent Redor CLA 2018-06-07 08:59:20 EDT
There are some non blocking issues but we considered this issue as validated. Above bugzillas will be fixed in a further version.
Comment 18 Laurent Redor CLA 2018-06-27 11:54:54 EDT
Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details