Bug 533568 - Generic editor leaks view model context forever
Summary: Generic editor leaks view model context forever
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.16.0   Edit
Hardware: All All
: P2 critical (vote)
Target Milestone: 1.17.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 18:06 EDT by Christian Damus CLA
Modified: 2018-04-17 09:25 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2018-04-13 18:06:52 EDT
The GenericEditor's view-model context is not disposed until the workbench is shut down.

The problem is that the TreeMasterDetailComposite created by the editor moves controls into a "limbo" shell off-screen, which is never disposed until the Display is disposed at shutdown of the platform.  Only then is the disposal hook that was added to the "limbo" shell by the AbstractSWTRenderer::finalizeRendering(Composite) method invoked to dispose the renderer and, therewith, the view-model context (by virtue of its last "user" being removed from it).
Comment 1 Eclipse Genie CLA 2018-04-13 18:13:56 EDT
New Gerrit change created: https://git.eclipse.org/r/121171
Comment 3 Christian Damus CLA 2018-04-17 09:25:26 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/121171 was merged to [develop].