Bug 532793 - reactivate support of ASP tags for older PHP versions
Summary: reactivate support of ASP tags for older PHP versions
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-22 19:11 EDT by Thierry BLIND CLA
Modified: 2020-05-14 11:25 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry BLIND CLA 2018-03-22 19:11:33 EDT
Hi,
everything is in the title ;)
The reason why asp tags support for the older php versions was "dropped" seems lost in space. And since it needed few changes to make it work again, I made a patch that cleans up short tags handling *AND* re-added support of ASP tags for PHP < 7.0. It made the patch bigger, but at the end it's more consistent.
I won't add specific unit tests for asp tags handling (since it's now deprecated and a little known feature), but I checked that all actual unit tests work the same when replacing <?php, <?=, <?, ?> tags by <%, <%=< and %>.

The day we don't support PHP 5.* versions anymore we can drop those code completely, but at least it helped to clean up things ;)

Thierry.
Comment 1 Thierry BLIND CLA 2018-03-22 19:17:07 EDT
Patch: https://git.eclipse.org/r/#/c/119830/
Comment 3 Thierry BLIND CLA 2018-03-23 06:35:03 EDT
Fixed.