Bug 531997 - Highlighters ignore catch statement and constant access
Summary: Highlighters ignore catch statement and constant access
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-05 03:52 EST by Dawid Pakula CLA
Modified: 2020-05-14 13:28 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2018-03-05 03:52:48 EST 
AS in subject, class and deprecation highlighter ignore catch:

try {} catch(\Exception $e) {}

class highlighter ignore constant access/call:

echo Foo::class;
echo Foo::$var;
echo Foo::call();
Comment 1 Thierry BLIND CLA 2018-03-10 17:51:32 EST 
Hi Dawid,
Sorry, I don't understand what you mean here, for me syntax coloring seems ok, have you some screenshot (or a more precise description), please? :)

Thierry.
Comment 2 Dawid Pakula CLA 2018-03-11 04:54:33 EDT 
I'm talking about class and deprecation higlighters (ClassHighlighting and DeprecatedHighlighting). This is visible in dark mode, for example check this file:

class Foo {
   const BAR = '';
}

try {
  echo Foo::BAR;
  // vs
  new Foo();
} catch(\Exception $e) {

}
Comment 3 Eclipse Genie CLA 2018-03-11 07:41:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/119173