Bug 531379 - Mark @param callback as well known type
Summary: Mark @param callback as well known type
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-20 06:03 EST by Dawid Pakula CLA
Modified: 2020-05-14 11:23 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2018-02-20 06:03:45 EST 
Lot's of PHP libraries use @param callback rather than @param callable or event php type hint callable.  We should ignore it in @param in same way like in other  phpdoc types.
Comment 1 Thierry BLIND CLA 2018-02-20 16:05:42 EST 
Sorry Dawid I don't really understand ;)
You mean that "@param callback" should be handled like "@param callable" ?
Comment 2 Dawid Pakula CLA 2018-02-20 16:07:30 EST 
Exactly, ignore in same way like mixed, callable, etc...
Comment 3 Thierry BLIND CLA 2018-02-20 17:05:00 EST 
Ok ;)

I've seen a strange thing in class PHPSimpleTypes:
shouldn't

public static final IEvaluatedType ITERABLE = new PHPClassType("callable");

be

public static final IEvaluatedType ITERABLE = new PHPClassType("iterable");

?

Michal did this modification for bug 519750, maybe he knows why he did that ;)

Thierry.
Comment 4 Thierry BLIND CLA 2018-02-21 14:50:45 EST 
(In reply to Thierry BLIND from comment #3)
> Ok ;)
> 
> I've seen a strange thing in class PHPSimpleTypes:
> shouldn't
> 
> public static final IEvaluatedType ITERABLE = new PHPClassType("callable");
> 
> be
> 
> public static final IEvaluatedType ITERABLE = new PHPClassType("iterable");
> 
> ?
> 
> Michal did this modification for bug 519750, maybe he knows why he did that
> ;)
> 
> Thierry.

Typo fixed in https://git.eclipse.org/r/#/c/117895/
Comment 5 Eclipse Genie CLA 2018-02-27 16:04:37 EST 
New Gerrit change created: https://git.eclipse.org/r/118311
Comment 7 Thierry BLIND CLA 2018-03-05 04:48:06 EST 
Fixed.