Bug 526224 - Problems with contexts in ValidationServiceImpl
Summary: Problems with contexts in ValidationServiceImpl
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.14.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 1.16.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-18 10:29 EDT by Christian Damus CLA
Modified: 2018-01-31 12:25 EST (History)
0 users

See Also:
eneufeld: iplog+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2017-10-18 10:29:49 EDT
EMF Forms 1.15 (version not available in bugzilla)
Eclipse Oxygen.1a

The ValidationServiceImpl (the emfforms.common one, not the ecp.view one) does not provide a consistent validation environment for the registered EMF-style EValidators to which it delegates.  In particular, when used to validate multiple objects, it does not do as the standard EMF Diagnostician does in two respects:

* it does not use the same substitution label provider in formulating messages
  for the "Diagnosis of ..." diagnostic-chains as is put in the validation context
  where validation rules find it.  Instead, these diagnostics are generated with
  the EcoreUtil::getIdentifier strings that cannot be presented to the user
* it creates a new validation context map for every object that it validates.  A
  Diagnostician provides a single map for all validator invocations to share, which
  allows for implementation of the EMF core containment cycles constraint as well as
  more complex validations such as uniqueness constraints
Comment 1 Eclipse Genie CLA 2017-10-18 10:40:14 EDT
New Gerrit change created: https://git.eclipse.org/r/110327
Comment 2 Eugen Neufeld CLA 2017-11-23 10:31:30 EST
CQ done in here: http://dev.eclipse.org/ipzilla/show_bug.cgi?id=14746
Comment 3 Christian Damus CLA 2017-11-27 08:47:03 EST
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/110327

This patch was merged (no genie?).
Comment 4 Eugen Neufeld CLA 2017-11-27 09:01:35 EST
I was waiting for the genie, this is why I didn't close it before.
Thanks for closing.
Comment 5 Christian Damus CLA 2018-01-31 12:25:24 EST
Close as fixed.