Description Thierry BLIND 2017-06-16 14:50:12 EDT

Hi,
after some discussion on the PDT-dev list, I think that patches for bug 515526 and bug 518128 should be reverted in the 5.0.1 branch, because after some testing, they break things more than they solved in the PHP editor, for example:
- compilation errors do not always disappear (annotations seem to be "stuck")
- variable highlighting stop to work pretty fastly
- unused variable highlighting (from the PDT extensions) also stop to work pretty fastly
- and Alex finds more and more deadlocks (see https://git.eclipse.org/r/#/c/99343/)

Only easy fix I found is to switch between editor tabs, it reset things afterwards (but problem will appear again).

Sadly patch for bug 515526 fixed a real bug (some syntax check errors were wrongly reported because ValidatorBuildParticipantFactory worked on an obsolete DLTK indexed source module), so reverting these patches will undo this fix.
But that's maybe not a so big problem compared to actual deadlocks and other discovered glitches. At the end, the most important is that users enjoy using PDT ;)

So @team, could you please take a bit of your time to test the actual 5.0 version (or master version) by "writing PHP code using the PHP editor" and compare it with the patch that will be attached to this bug report?

Please use flag "+" if you prefer PDT with this patch applied and "-" if you prefer PDT in its actual state. Remember that planned 5.0.1 release date is June 28 ;)

Thierry.