Bug 517722 - Multiple "Launch Groups" launch configuration
Summary: Multiple "Launch Groups" launch configuration
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 9.3.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 9.3.0   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-02 09:52 EDT by Jonah Graham CLA
Modified: 2017-06-05 08:12 EDT (History)
4 users (show)

See Also:


Attachments
two launch groups (63.94 KB, image/png)
2017-06-02 09:52 EDT, Jonah Graham CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2017-06-02 09:52:56 EDT
Created attachment 268721 [details]
two launch groups

In Bug 492788 Launch Groups were promoted to Core Debug from CDT (yay!). However that has left in Oxygen two launch groups launch types if CDT is installed. See screenshot.
Comment 1 Elena Laskavaia CLA 2017-06-02 10:31:47 EDT
We have to do migrate old one to new once to remove them completely.... 
Unfortunately migrate is not automatic functionality
Comment 2 Markus Duft CLA 2017-06-02 10:32:00 EDT
Hm. Not so nice... Actually there is nothing really figured out on removing it from CDT. The most simple thing to do right now would be (for Oxygen) to remove the extension point registration for the CDT launch group elements - I don't have them all at hand, so you'd need to search for those.

On migrating individual configurations: it should be possible to "migrate" to the core debug version by changing the launch configuration type ID in the actual launch configurations.

Unfortunately I need to run now, so I cannot lookup more information. I'll be back on 8th of June, then I could help
Comment 3 Jonah Graham CLA 2017-06-02 11:16:02 EDT
Thanks Elena and Markus.

(In reply to Elena Laskavaia from Bug 492788 comment #31)
> Yes ID has to change to platform debug one. We are prepared to write
> a migration delegate (although its sucks that this is not invoked
> automatically)

I am correct in assuming that this was never written. It certainly isn't in CDT.



(In reply to Elena Laskavaia from comment #1)
> We have to do migrate old one to new once to remove them completely.... 
> Unfortunately migrate is not automatic functionality

I assume you mean that the user has to press the "Migrate" button in Preferences -> Run/Debug -> Launching -> Launch Configurations?
Comment 4 Jonah Graham CLA 2017-06-02 12:49:29 EDT
(In reply to Jonah Graham from comment #3)
> I am correct in assuming that this was never written. It certainly isn't in
> CDT.


That was meant to be phrased as a question, "Am I correct..."
Comment 5 Elena Laskavaia CLA 2017-06-02 15:48:53 EDT
IMHO we should just change name of this LC type
and add (Deprecated) word it in.
Document that it will be removed, ask used to migrate manually (recreate manually - no programmatic help).
Remove from next release (Oxygen +1).
Comment 6 Jonah Graham CLA 2017-06-02 17:06:03 EDT
Thanks Elena, 

That would make life simpler! I'll do that instead of trying to write a converter. 

Jonah
Comment 7 Eclipse Genie CLA 2017-06-05 06:05:18 EDT
New Gerrit change created: https://git.eclipse.org/r/98617
Comment 9 Jonah Graham CLA 2017-06-05 07:03:22 EDT
To migrate an existing Group Launch Configuration from CDT's deprecated format to the Platform format simply edit the .launch file and change the following things (with Eclipse not running).

Change:
  <launchConfiguration type="org.eclipse.cdt.launch.launchGroup">
to:
  <launchConfiguration type="org.eclipse.debug.core.groups.GroupLaunchConfigurationType">

Change all the key prefixes from:
  org.eclipse.cdt.launch.launchGroup
to:
  org.eclipse.debug.core.launchGroup

Change the attribute type for "[...].enabled" attributes from:
  stringAttribute
to:
  booleanAttribute


If your .launch file is not stored in your project, it can be found in workspace/.metadata/.plugins/org.eclipse.debug.core/.launches
Comment 10 Eclipse Genie CLA 2017-06-05 07:47:29 EDT
New Gerrit change created: https://git.eclipse.org/r/98623
Comment 11 Jonah Graham CLA 2017-06-05 07:55:54 EDT
Added wiki page https://wiki.eclipse.org/CDT/User/LaunchGroupMigrationInfo with migration info from Comment 9
Comment 13 Jonah Graham CLA 2017-06-05 08:12:12 EDT
(In reply to Eclipse Genie from comment #12)
> Gerrit change https://git.eclipse.org/r/98623 was merged to [master].
> Commit:
> http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/
> ?id=ad97076c4d323cf8aaa60e9f3b6f5c057eae705b

Everything has been marked deprecated, the actual removal is tracked in Bug 517813