Bug 516423 - Display of Show/Hide popup is too long
Summary: Display of Show/Hide popup is too long
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 4.1.1   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 6.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Guillaume Coutable CLA
URL:
Whiteboard:
Keywords: performance, triaged
Depends on:
Blocks: 533860
  Show dependency tree
 
Reported: 2017-05-10 11:10 EDT by Julien Dupont CLA
Modified: 2018-06-27 11:55 EDT (History)
5 users (show)

See Also:


Attachments
Big model (4.91 MB, application/x-gzip)
2017-05-10 11:10 EDT, Julien Dupont CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Dupont CLA 2017-05-10 11:10:17 EDT
Created attachment 268272 [details]
Big model

With a diagram with 1000 elements displayed the display of Show/Hide popup is too longer.

Steps to reproduce:
- Import use case reverse-sirius-10times-2015-01-22T12-45.tar.gz
- Select in the semantic model all packages in revers1.ecore/full-sirius-code (there are about 1000 packages)
- Drag'n drop all packages in full-sirius-code class Diagram

Click on Show\Hide (from tabbar or from popup menu)
The popup takes a long time to display
Comment 1 Cedric Brun CLA 2017-05-10 11:12:33 EDT
> The popup takes a long time to display

Could you just say what "long" means in your case (in seconds, minutes) even if it's 'on your machine' this is useful to get an idea of what kind of potential gain we are looking at.
Comment 2 Julien Dupont CLA 2017-05-10 11:14:52 EDT
Between 30s and 45seconds on my machine (Win64) and maybe faster on an Linux machine but very long too.
Comment 3 Julien Dupont CLA 2017-05-10 11:21:17 EDT
This problem has been posted on the forum: https://www.eclipse.org/forums/index.php/t/1086120/
Comment 4 Cedric Brun CLA 2017-05-10 11:23:04 EDT
Thanks! this gives indeed a pretty good idea.

It should be checked and it's only assumption at this point, but it could be that we are hitting another case of "SWT filtered Tree which is not caching the result" See this comment and the corresponding work done for Sirius 3.0 in the case of the "Create Representation" wizard:
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=463732#c5
Comment 5 Hendrik Buender CLA 2018-02-21 09:39:04 EST
We updated to Sirius 5.1.0, however, the bug is still occurring. Are you planning to takle this issue?
Comment 6 Eclipse Genie CLA 2018-04-20 05:15:45 EDT
New Gerrit change created: https://git.eclipse.org/r/121459
Comment 7 Pierre Guilet CLA 2018-04-20 05:43:44 EDT
With the fix, we reduce the time to show the wizard with 2166 elements from 36s to less than 1 second.
Comment 8 Pierre-Charles David CLA 2018-04-20 05:46:52 EDT
(In reply to Hendrik Buender from comment #5)
> We updated to Sirius 5.1.0, however, the bug is still occurring. Are you
> planning to takle this issue?

It should be fixed in 6.0M7 and we'll probably backport it on 5.1.x.
Comment 10 Guillaume Coutable CLA 2018-05-24 11:19:53 EDT
Validated with Sirius 6.0M7
Comment 11 Laurent Redor CLA 2018-06-27 11:55:15 EDT
Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details