Bug 501049 - Binding for Open PHP Type doesn't work in Project Explorer
Summary: Binding for Open PHP Type doesn't work in Project Explorer
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact: Sylvia Tancheva CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 478814
  Show dependency tree
 
Reported: 2016-09-08 04:43 EDT by Michal Niewrzal CLA
Modified: 2020-05-14 13:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2016-09-08 04:43:36 EDT 
It works only if selection is on PHP model element.
Comment 1 Thierry BLIND CLA 2016-09-08 06:25:26 EDT 
Sorry Michal, it may sound stupid, what do you mean with "Open PHP Type" in Project Explorer? :) I'm a bit lost ;)
Comment 2 Michal Niewrzal CLA 2016-09-08 06:29:00 EDT 
No problem :) 'Open PHP Type' dialog available under Shift+Ctrl+T shortcut or from main menu Navigate -> Open Type.

I noticed that there is the same problem for 'Open Method' dialog.
Comment 3 Michal Niewrzal CLA 2016-09-08 06:30:48 EDT 
And main problem is that Shift+Ctrl+T is not always working inside Project Explorer.
Comment 4 Thierry BLIND CLA 2016-09-08 06:35:40 EDT 
Ok thank you now I understand ;)
Strangely I see no error on my side, maybe I do only some basic use for now!
Comment 5 Michal Niewrzal CLA 2016-09-08 06:43:20 EDT 
Hmm maybe I will describe my workflow with details:
* Open PHP Perspective
* Open Project Explorer, close PHP Explorer
* Create PHP project
* Create file test.txt
* Select this file and try Ctrl+Shift+T
* In my case 'Open PHP Type' dialog is not opening
Comment 6 Thierry BLIND CLA 2016-09-08 07:04:02 EDT 
Ok I could reproduce it with your description, thank you Michal :)
I never hit this bug before, because I always use the PHP Explorer!
Comment 7 Michal Niewrzal CLA 2016-09-08 07:05:49 EDT 
Me too but now when we are thinking about replacing PHP Explorer with Project Explorer I started to check things here and there :)
Comment 8 Thierry BLIND CLA 2016-09-08 08:19:56 EDT 
Please stop finding bugs ! ;) I'm joking ! ;)
Comment 9 Michal Niewrzal CLA 2016-10-11 18:31:17 EDT 
At the moment I cannot find satisfying solution for this. Mainly because every attempt to fix this finish with conflict with JDT and theirs Ctlr+Shift+T :)

As workaround/enhancement maybe we can add Open PHP Type and Open PHP Method to perspective toolbar? We have place there.
Comment 10 Thierry BLIND CLA 2016-10-12 09:08:43 EDT 
We can make a try ;) I see that more like a workaround, generally I'm a heavy keyboard shortcut user ;)
Comment 11 Eclipse Genie CLA 2018-03-18 07:39:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/119629
Comment 12 Eclipse Genie CLA 2018-03-18 07:52:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/119630