Bug 496598 - [Utilities] CommandTreeIterator does not follow wrapper chains
Summary: [Utilities] CommandTreeIterator does not follow wrapper chains
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-22 20:16 EDT by Christian Damus CLA
Modified: 2017-05-10 04:22 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2016-06-22 20:16:07 EDT 
In the 2.0.0 API refactorings, a new CommandTreeIterator class was introduced in the org.eclipse.papyrus.infra.emf.gmf bundle to supersede the deprecated class in the org.eclipse.papyrus.infra.gmfdiag.commands bundle.  Like its predecessor, it unwraps any recognized command-wrapper that it encounters.  But, unlike its predecessor, it doesn't then recursively check the unwrapped result to see whether it, too, is a wrapper (etc.)

Consequently, in some wacky re-wrapped command chains that come from certain GMF service providers, leaf commands are not found because the iterator is stymied by a wrapper.
Comment 1 Eclipse Genie CLA 2016-06-22 20:45:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/75787
Comment 2 Eclipse Genie CLA 2016-06-22 21:30:28 EDT 
New Gerrit change created: https://git.eclipse.org/r/75788
Comment 4 Eclipse Genie CLA 2016-06-22 23:13:22 EDT 
Gerrit change https://git.eclipse.org/r/75787 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=fcdc5f899c26ae32a1a6fc35ec1613b2129ac7c7
Comment 5 Christian Damus CLA 2016-06-22 23:14:15 EDT 
(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/75787 was merged to
> [streams/2.0-maintenance].

(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/75788 was merged to [master].
Comment 6 Eclipse Genie CLA 2016-06-23 08:02:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/75833
Comment 7 Eclipse Genie CLA 2016-06-24 16:42:59 EDT 
Gerrit change https://git.eclipse.org/r/75833 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=2f504974d0cc3f922ca0290b6d21ac881948f283
Comment 8 Eclipse Genie CLA 2016-06-24 17:12:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/75952