Bug 495753 - Preference pages have inconsistent layouts
Summary: Preference pages have inconsistent layouts
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: UI (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows 10
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Simon Delisle CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-08 16:14 EDT by Andreas Mayer CLA
Modified: 2016-11-07 11:42 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Mayer CLA 2016-06-08 16:14:30 EDT
By now, EMF Compare has half a dozen preference pages. Unfortunately, there are lots of tiny differences in the layouts that make them unsightly:

* "Engines"
    - vertical gap between label and viewer is too large
    - viewer is indented (why?), but the description for the selected
      engine is not
    - description should have same background as the tab items

* "Filters"
    - margin too wide
    - viewer is indented (with a smaller indentation as in "Engines"),
      but the description for the selected engine is not
    - border around filter viewer and description is unnecessary
        - add a vertical gap between the filter viewer/description and
          "Automatic behavior" instead

* "Filter" with the new active/enabled tab items
    - introduction is wrapped with hard line endings, which looks ugly
      (spaces at the line starts, short lines, ...) if the dialog is
      resized
        - remove all \n in the texts, add a GridData with
          HORIZONTAL_FILL and a width hint, and the labels will
          be wrapped just fine

* "Groups"
    - margin too wide
    - description should have same background as the tab items
    - same unnecessary border around filter viewer and description as
      in "Filters", but the label for this group is outside the border
      this time
          - use a vertical gap between the group and "Automatic 
            behavior" instead

* "Item Groups"
    - page name should use title case
    - beveled border (from an SWT Group), which visually separates
      the label and viewer from the description
    - viewer (or rather the containing group) is indented in relation
      the accompanying description

* "Logging"
    - unnecessary border and label (the page is already titled "Logging")

* "Post Processors"
    - viewer is indented

* "Resolution strategy"
    - page name should use title case
Comment 1 Philip Langer CLA 2016-06-09 03:50:55 EDT
+1

I completely agree! Would be very nice to rework them a bit and make them scalable with a consistent look!
Comment 2 Simon Delisle CLA 2016-06-22 13:19:47 EDT
Have you started working on this ?
Comment 3 Andreas Mayer CLA 2016-06-22 14:02:04 EDT
(In reply to Simon Delisle from comment #2)
> Have you started working on this ?

No. And it seems I will be busy with other things for the foreseeable future.
Comment 4 Eclipse Genie CLA 2016-06-30 10:55:59 EDT
New Gerrit change created: https://git.eclipse.org/r/76348
Comment 6 Philip Langer CLA 2016-11-07 11:14:00 EST
I think, we can close this, as the fix has been merged. Or are there any open issues with regard to the property pages? If no, Simon, can you please close it?

Thanks for the fix!
Comment 7 Laurent Delaigue CLA 2016-11-07 11:16:42 EST
I agree, this has been merged and is available in EMF Compare 3.3.0.
I mark it as resolved fixed. Simon, please close it if you consider it fully over.
Comment 8 Simon Delisle CLA 2016-11-07 11:42:50 EST
No open issues remaining, we can close it.