Community
Participate
Working Groups
By now, EMF Compare has half a dozen preference pages. Unfortunately, there are lots of tiny differences in the layouts that make them unsightly: * "Engines" - vertical gap between label and viewer is too large - viewer is indented (why?), but the description for the selected engine is not - description should have same background as the tab items * "Filters" - margin too wide - viewer is indented (with a smaller indentation as in "Engines"), but the description for the selected engine is not - border around filter viewer and description is unnecessary - add a vertical gap between the filter viewer/description and "Automatic behavior" instead * "Filter" with the new active/enabled tab items - introduction is wrapped with hard line endings, which looks ugly (spaces at the line starts, short lines, ...) if the dialog is resized - remove all \n in the texts, add a GridData with HORIZONTAL_FILL and a width hint, and the labels will be wrapped just fine * "Groups" - margin too wide - description should have same background as the tab items - same unnecessary border around filter viewer and description as in "Filters", but the label for this group is outside the border this time - use a vertical gap between the group and "Automatic behavior" instead * "Item Groups" - page name should use title case - beveled border (from an SWT Group), which visually separates the label and viewer from the description - viewer (or rather the containing group) is indented in relation the accompanying description * "Logging" - unnecessary border and label (the page is already titled "Logging") * "Post Processors" - viewer is indented * "Resolution strategy" - page name should use title case
+1 I completely agree! Would be very nice to rework them a bit and make them scalable with a consistent look!
Have you started working on this ?
(In reply to Simon Delisle from comment #2) > Have you started working on this ? No. And it seems I will be busy with other things for the foreseeable future.
New Gerrit change created: https://git.eclipse.org/r/76348
Gerrit change https://git.eclipse.org/r/76348 was merged to [master]. Commit: http://git.eclipse.org/c/emfcompare/org.eclipse.emf.compare.git/commit/?id=10679ac6b633f8877a0ed83c2cfd6d44ed791cbc
I think, we can close this, as the fix has been merged. Or are there any open issues with regard to the property pages? If no, Simon, can you please close it? Thanks for the fix!
I agree, this has been merged and is available in EMF Compare 3.3.0. I mark it as resolved fixed. Simon, please close it if you consider it fully over.
No open issues remaining, we can close it.