Community
Participate
Working Groups
Bug 488909 improved the code base by merging GdbDebugServicesFactory and GdbDebugServicesFactoryNS. However it left an unusually hard to cope with API change due to removing GdbDebugServicesFactoryNS class and the GdbDebugServicesFactory(String) constructor. This bug is to leave the code base merged, but provide the API to construct the improved class.
Cross referencing the the mailing list discussion on this: https://dev.eclipse.org/mhonarc/lists/cdt-dev/msg30724.html
New Gerrit change created: https://git.eclipse.org/r/73559
New Gerrit change created: https://git.eclipse.org/r/73574
I haven't looked at the Gerrit proposals yet but my hope was to find a (incomplete but) sufficient solution without reintroducing the GdbDebugServicesFactoryNS. Maybe that's not possible?
(In reply to Marc Khouzam from comment #4) > I haven't looked at the Gerrit proposals yet but my hope was to find a > (incomplete but) sufficient solution without reintroducing the > GdbDebugServicesFactoryNS. > > Maybe that's not possible? Sorry, we don't need GdbDebugServicesFactoryNS for Liviu's case. I was reverting the entire API for the cleanup, without losing the "goodness" of the cleanup. We don't have to resurrect GdbDebugServicesFactoryNS.
The proposed solution is even better than I expected. Looking at the most likely way extenders would have been using this API, I believe the proposed new API will allow them to continue working with all-stop and non-stop even if they don't migrate to the new constructor. I verified this with the GdbExtendedLaunchDelegate as it was written for the old, API and confirmed that both all-stop and non-stop are still handled properly. Thanks Jonah, this change is how I should have done it from the start.
Gerrit change https://git.eclipse.org/r/73574 was merged to [cdt_9_0]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=6002c2abb0782e6adc8307ade4b2ff782748f549
Gerrit change https://git.eclipse.org/r/73559 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=69d3441795a73a0c80a0ca3d5cfa0dcdfa50b0b0
Updated N&N API Modifications section for this change. (Note change is in a moderation queue so may not be visible yet.)